Minor improvements

Author: JulianGCalderon

hint_accountant/src/main.rs

@@ -2,7 +2,6 @@
 #![forbid(unsafe_code)]
 use std::fs::{self, File};
 use std::io::BufReader;
-use std::rc::Rc;
 
 use cairo_vm::stdlib::collections::{HashMap, HashSet};
 use cairo_vm::{
@@ -69,7 +68,7 @@ fn run() {
                     &ap_tracking_data,
                     &reference_ids,
                     &references,
-                    Rc::default(),
+                    Default::default(),
                 )
                 .expect("this implementation is infallible");
             matches!(

vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs

@@ -1450,14 +1450,14 @@ mod tests {
         let hint_data =
             HintProcessorData::new_default(String::from("enter_scope_custom_a"), HashMap::new());
         assert_matches!(
-            hint_processor.execute_hint(&mut vm, exec_scopes, &any_box!(hint_data),),
+            hint_processor.execute_hint(&mut vm, exec_scopes, &any_box!(hint_data)),
             Ok(())
         );
         assert_eq!(exec_scopes.data.len(), 2);
         let hint_data =
             HintProcessorData::new_default(String::from("enter_scope_custom_a"), HashMap::new());
         assert_matches!(
-            hint_processor.execute_hint(&mut vm, exec_scopes, &any_box!(hint_data),),
+            hint_processor.execute_hint(&mut vm, exec_scopes, &any_box!(hint_data)),
             Ok(())
         );
         assert_eq!(exec_scopes.data.len(), 3);

vm/src/hint_processor/cairo_1_hint_processor/hint_processor.rs

@@ -9,6 +9,7 @@ use super::hint_processor_utils::*;
 use crate::any_box;
 use crate::hint_processor::cairo_1_hint_processor::dict_manager::DictSquashExecScope;
 use crate::hint_processor::hint_processor_definition::HintReference;
+use crate::stdlib::rc::Rc;
 use crate::stdlib::{boxed::Box, collections::HashMap, prelude::*};
 use crate::types::relocatable::{MaybeRelocatable, Relocatable};
 use crate::vm::runners::cairo_runner::ResourceTracker;
@@ -30,7 +31,6 @@ use cairo_lang_casm::{
 };
 use core::any::Any;
 use core::ops::Shl;
-use std::rc::Rc;
 
 use num_bigint::{BigInt, BigUint};
 use num_integer::{ExtendedGcd, Integer};

vm/src/hint_processor/hint_processor_definition.rs

@@ -1,6 +1,4 @@
-use std::rc::Rc;
-
-use crate::stdlib::{any::Any, boxed::Box, collections::HashMap, prelude::*};
+use crate::stdlib::{any::Any, boxed::Box, collections::HashMap, prelude::*, rc::Rc};
 
 use crate::any_box;
 use crate::serde::deserialize_program::ApTracking;
@@ -50,7 +48,7 @@ pub trait HintProcessorLogic {
             code: hint_code.to_string(),
             ap_tracking: ap_tracking_data.clone(),
             ids_data: get_ids_data(reference_ids, references)?,
-            constants: constants.clone(),
+            constants,
         }))
     }
 

vm/src/tests/run_deprecated_contract_class_simplified.rs

@@ -1,5 +1,4 @@
 #![cfg(feature = "extensive_hints")]
-use std::rc::Rc;
 
 /* This file contains a test that runs the program: cairo_programs/starknet_os_deprecated_cc.cairo
    For testsing purposes, the contract ran by this program is hardcoded, with values taken from compiling:
@@ -16,7 +15,7 @@ use std::rc::Rc;
    The purpose of this test is to check the functionality of the HintProcessor::execute_hint_extensive functionality
    And to show a very simplified example on how it can be used to achieve the `vm_load_data` functionality used by starknet os programs
 */
-use crate::stdlib::{collections::HashMap, prelude::*};
+use crate::stdlib::{collections::HashMap, prelude::*, rc::Rc};
 
 use crate::Felt252;
 use num_traits::Zero;
@@ -298,7 +297,7 @@ pub fn vm_load_program(
         &hint_ap_tracking_data,
         &reference_ids,
         &references,
-        Rc::default(),
+        Default::default(),
     )?;
     // Create the hint extension
     // As the hint from the compiled constract has offset 0, the hint pc will be equal to the loaded contract's program base:

vm/src/vm/runners/cairo_runner.rs

@@ -1,5 +1,3 @@
-use std::rc::Rc;
-
 use crate::{
     air_private_input::AirPrivateInput,
     air_public_input::{PublicInput, PublicInputError},
@@ -9,6 +7,7 @@ use crate::{
         collections::{BTreeMap, HashMap, HashSet},
         ops::{Add, AddAssign, Mul, MulAssign, Sub, SubAssign},
         prelude::*,
+        rc::Rc,
     },
     types::{builtin_name::BuiltinName, layout::CairoLayoutParams, layout_name::LayoutName},
     vm::{