Skip to content

Commit 6713166

Browse files
authored
Merge pull request #84 from lad-tech/81-add-stacktrace-in-error-message
feat: add stack in error log message
2 parents a043b5c + b54dd51 commit 6713166

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

src/Root.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,14 @@ export class Root {
5858
}
5959
}
6060

61-
protected buildErrorMessage(error: string | Error, code?: number) {
61+
protected buildErrorMessage(error: string | Error | Record<any, any>, code?: number) {
6262
let message = '';
6363
if (error instanceof Error) {
6464
message = error.message;
65-
} else {
65+
} else if (typeof error === 'string') {
6666
message = error;
67+
} else {
68+
message = JSON.stringify(error);
6769
}
6870
return {
6971
payload: null,

src/Service.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,12 +419,22 @@ export class Service<E extends Emitter = Emitter> extends Root {
419419
return result;
420420
} catch (error) {
421421
logger.debug({ request: payload });
422-
logger.error(error);
422+
logger.error(this.createErrorMessageForLogger(error));
423423
this.finishSpan(span, error);
424424
return this.buildErrorMessage(error);
425425
}
426426
}
427427

428+
/**
429+
* Make error object if error instance of Error object for logger
430+
*/
431+
private createErrorMessageForLogger(error: any) {
432+
if (error instanceof Error) {
433+
return { name: error.name, message: error.message, stack: error.stack };
434+
}
435+
return { message: JSON.stringify(error) };
436+
}
437+
428438
/**
429439
* Start service. Subscribe for subject and up http server
430440
*/

0 commit comments

Comments
 (0)