Add prefer-align-cpus-by-uncorecache feature gate #48340

wongchar · 2024-10-14T15:56:46Z

Description

Add documentation for new alpha feature gate: prefer-align-cpus-by-uncorecache

Issue

kubernetes/enhancements#4800
kubernetes/kubernetes#126750

k8s-ci-robot · 2024-10-14T15:56:55Z

Welcome @wongchar!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2024-10-14T15:57:02Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`ace1c3b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67460fbbf7ce880008e53186

netlify · 2024-10-14T16:06:07Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`ace1c3b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67460fbbd6c6120008974e30
😎 Deploy Preview	https://deploy-preview-48340--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tengqm · 2024-10-15T01:12:13Z

This commit should be rebased onto dev-1.32 head, IIUC.

ffromani · 2024-11-19T18:07:41Z

Hi @sftim ! My understanding is we have time to the doc freeze and Nov 19 was the deadline to have documentation PRs submitted and ready for review (not merged!)

If my understanding is right I'm willing to help to kickoff the aforementioned concepts page.

sftim · 2024-11-19T18:16:27Z

@ffromani that's right. Help is welcome!

ffromani · 2024-11-19T18:18:16Z

@ffromani that's right. Help is welcome!

ok! I'm willing to take a stab! (xref: #38121)

ffromani · 2024-11-21T11:40:59Z

@ffromani that's right. Help is welcome!

ok! I'm willing to take a stab! (xref: #38121)

here: #48797

ffromani

LGTM from sig-node. Technical content looks correct to me.

chanieljdan · 2024-11-22T13:45:56Z

Technical lgtm provided above

/lgtm

chanieljdan · 2024-11-22T13:47:52Z

@reylejano when you get the chance we just need your final review and approval for this one. Thanks!

sftim · 2024-11-22T14:02:44Z

content/en/docs/tasks/administer-cluster/cpu-management-policies.md

If we can get #48797 merged and merged into v1.32 docs, then the changes here can go there instead (which is what I recommend doing).

See #48340 (review)

I'm willing to help with #48797, but @tengqm raised some points about the feasibility in the 1.32 timeframe. I guess we can figure out during the review of #48797 ?

Something else we can do: merge this as-is, but track some work to do after the release to make the docs more readable.

Adding this extra detail harms the quality and readability of the existing task page, so we should plan that work, but we can accept that harm and not block adding this alpha feature on having it appropriately documented.

Ideally we do block beta graduation on getting the docs redone, though. Beta features should have docs that we think are GA quality (and we ship them to find out).

I can and will work on getting #48797 ready anyway (https://kubernetes.slack.com/archives/C0BP8PW9G/p1732284959539839). If we decide to not merge for 1.32 due to the too strict timeline, I'll rebase once the other linked content landed, and once cpumanager content is settled I'll move on to memory manager and others:

cpumanager

memory manager

topology manager

(perhaps) device manager, this component doesn't have policies so it can use some refactoring but probably doesn't belong here.

sftim · 2024-11-22T14:13:38Z

Waiting for docs LGTM
Tech LGTMs noted

/lgtm cancel

wongchar · 2024-11-26T18:16:15Z

Rebased to @ffromani 's PR (#48856). Thanks!

@sftim PTAL when you get a chance.

ffromani

LGTM

from sig-node

ffromani · 2024-11-26T18:18:47Z

content/en/docs/concepts/policy/node-resource-managers.md

+: Allocate virtual cores, sometimes called hardware threads, across different physical cores  (available since Kubernetes v1.31)
 `distribute-cpus-across-numa` (alpha, hidden by default)
-: spread CPUs across different NUMA domains, aiming for an even balance between the selected domains (available since Kubernetes v1.23)
+: Spread CPUs across different NUMA domains, aiming for an even balance between the selected domains (available since Kubernetes v1.23)


this is unrelated fix I asked @wongchar to pull in

ffromani · 2024-11-26T18:19:41Z

content/en/docs/concepts/policy/node-resource-managers.md

+`strict-cpu-reservation` (alpha, hidden by default)
+: Prevent all the pods regardless of their Quality of Service class to run on reserved CPUs (available since Kubernetes v1.32)


Same, fixing a rebase artifact of my previous #48797

ffromani · 2024-11-26T18:20:01Z

...ocs/reference/command-line-tools-reference/feature-gates/prefer-align-cpus-by-uncorecache.md

+    defaultValue: false
+    fromVersion: "1.32"
+---
+When `PreferAlignCpusByUncoreCache` is enabled while the CPU Manager Policy is set to `static`, containers within a `Guaranteed` pod will individually be aligned to an uncore cache group at a best-effort policy. This feature can optimize performance for certain cache-sensitive workloads by minimizing the cpu allocation across uncore caches.


fixed in the last upload after rebase on top of #48797

katcosgrove · 2024-11-26T18:21:46Z

/lgtm

/assign @chanieljdan

k8s-ci-robot · 2024-11-26T18:21:53Z

LGTM label has been added.

Git tree hash: 8bbd308be16094fd1c9f8c8c63b695d845fb8d3b

chanieljdan · 2024-11-26T18:23:29Z

tech and docs lgtm provided

/approve

k8s-ci-robot · 2024-11-26T18:23:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanieljdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [chanieljdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added this to the 1.32 milestone Oct 14, 2024

k8s-ci-robot requested review from Arhell and asa3311 October 14, 2024 15:56

k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Oct 14, 2024

wongchar mentioned this pull request Oct 14, 2024

Split L3 Cache Topology Awareness in CPU Manager kubernetes/enhancements#4800

Closed

4 tasks

ajcaldelas force-pushed the split-uncorecache-awareness branch from ae9f6d5 to 6989bb5 Compare October 14, 2024 17:04

ajcaldelas force-pushed the split-uncorecache-awareness branch from 6989bb5 to 35e7e1d Compare October 15, 2024 13:57

ffromani mentioned this pull request Nov 21, 2024

node: start moving the resource management docs to concepts #48797

Merged

ffromani reviewed Nov 21, 2024

View reviewed changes

k8s-ci-robot assigned chanieljdan Nov 22, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024

sftim reviewed Nov 22, 2024

View reviewed changes

k8s-ci-robot assigned sftim Nov 22, 2024

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024

k8s-ci-robot requested a review from chanieljdan November 22, 2024 14:13

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

update docs for prefer-align-cpus-by-uncorecache feature

ace1c3b

wongchar force-pushed the split-uncorecache-awareness branch from b96af01 to ace1c3b Compare November 26, 2024 18:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

ffromani reviewed Nov 26, 2024

View reviewed changes

k8s-ci-robot assigned katcosgrove Nov 26, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024

k8s-ci-robot merged commit b581326 into kubernetes:dev-1.32 Nov 26, 2024
6 checks passed

ajcaldelas mentioned this pull request Jan 30, 2025

Split L3 Cache Topology Awareness in CPU Manager kubernetes/enhancements#5109

Open

22 tasks

		`strict-cpu-reservation` (alpha, hidden by default)
		: Prevent all the pods regardless of their Quality of Service class to run on reserved CPUs (available since Kubernetes v1.32)

Add prefer-align-cpus-by-uncorecache feature gate #48340

Add prefer-align-cpus-by-uncorecache feature gate #48340

Uh oh!

Conversation

wongchar commented Oct 14, 2024

Description

Issue

Uh oh!

k8s-ci-robot commented Oct 14, 2024

Uh oh!

netlify bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

netlify bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

tengqm commented Oct 15, 2024

Uh oh!

ffromani commented Nov 19, 2024

Uh oh!

sftim commented Nov 19, 2024

Uh oh!

ffromani commented Nov 19, 2024

Uh oh!

ffromani commented Nov 21, 2024

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

chanieljdan commented Nov 22, 2024

Uh oh!

chanieljdan commented Nov 22, 2024

Uh oh!

sftim Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

ffromani Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

sftim Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

ffromani Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

sftim commented Nov 22, 2024

Uh oh!

wongchar commented Nov 26, 2024

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

ffromani Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

ffromani Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

ffromani Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

katcosgrove commented Nov 26, 2024

Uh oh!

k8s-ci-robot commented Nov 26, 2024

Uh oh!

chanieljdan commented Nov 26, 2024

Uh oh!

k8s-ci-robot commented Nov 26, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

netlify bot commented Oct 14, 2024 •

edited

Loading

netlify bot commented Oct 14, 2024 •

edited

Loading