Skip to content

graduate MatchLabelKeysInPodAffinity to beta #45181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2024
Merged

graduate MatchLabelKeysInPodAffinity to beta #45181

merged 6 commits into from
Jul 25, 2024

Conversation

@sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Feb 17, 2024

The doc update to graduate MatchLabelKeysInPodAffinity to beta.
Part of kubernetes/enhancements#3633

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2024
@netlify
Copy link

netlify bot commented Feb 17, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 483138f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/666951b314bfc40008aa97c0

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 17, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 17, 2024
@sanposhiho sanposhiho mentioned this pull request Feb 17, 2024
Closed
12 tasks
@dipesh-rawat
Copy link
Member

dipesh-rawat commented Feb 17, 2024

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 17, 2024
sftim
sftim reviewed Feb 17, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

dipesh-rawat
dipesh-rawat reviewed Feb 18, 2024
View reviewed changes
dipesh-rawat
dipesh-rawat reviewed Feb 18, 2024
View reviewed changes
@sanposhiho
Copy link
Member Author

sanposhiho commented Feb 24, 2024

@dipesh-rawat Thanks, updated.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2024
@sanposhiho sanposhiho force-pushed the matchlabelkeys-graduate branch from f1ab2d6 to 49882b3 Compare February 24, 2024 06:33
@sanposhiho sanposhiho force-pushed the matchlabelkeys-graduate branch from 49882b3 to 8a02947 Compare February 24, 2024 06:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2024
@sanposhiho
Copy link
Member Author

sanposhiho commented Feb 24, 2024

/cc @Huang-Wei

@tengqm
Copy link
Contributor

tengqm commented Feb 24, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 24, 2024

LGTM label has been added.

Git tree hash: c265863973008045d6dc090e44e51422af0dc2b5

@tengqm tengqm added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 24, 2024
@sanposhiho
Correct the grammar
22630de 
Co-authored-by: Tim Bannister <[email protected]>
@sanposhiho
Copy link
Member Author

sanposhiho commented Mar 10, 2024

Unfortunately we couldn't make it in the code freeze.

kubernetes/enhancements#3633 (comment)

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2024

@sanposhiho: Closed this PR.

In response to this:

Unfortunately we couldn't make it in the code freeze.

kubernetes/enhancements#3633 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@drewhagen
Copy link
Member

drewhagen commented Apr 26, 2024

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the new release.

@sanposhiho
Copy link
Member Author

sanposhiho commented Jun 12, 2024

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 12, 2024

@sanposhiho: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 12, 2024
@sanposhiho sanposhiho changed the base branch from dev-1.30 to dev-1.31 June 12, 2024 07:00
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024
@netlify
Copy link

netlify bot commented Jun 12, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 773bcaf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/666947c981ceec0008a46426
😎 Deploy Preview https://deploy-preview-45181--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 483138f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/666951b39610680008e1ebfa
😎 Deploy Preview https://deploy-preview-45181--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Princesso
Princesso reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Princesso Princesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2024

LGTM label has been added.

Git tree hash: 817a456fffbb8ef0650a393264cbc4574cddb286

@hacktivist123
Copy link
Contributor

hacktivist123 commented Jul 25, 2024

Hello @sanposhiho 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 25, 2024

/cc @Huang-Wei

for the review from SIG.

Who should I ask for the approval from SIG-docs?

Huang-Wei
Huang-Wei reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Huang-Wei
Huang-Wei reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Princesso
Copy link
Contributor

Princesso commented Jul 25, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, Princesso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 108e2a9 into kubernetes:dev-1.31 Jul 25, 2024
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@davidopp davidopp Awaiting requested review from davidopp

@windsonsea windsonsea Awaiting requested review from windsonsea

+4 more reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Princesso Princesso Princesso left review comments

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

@Princesso Princesso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

SIG Scheduling
Archived in project

Milestone

1.31

Development

Successfully merging this pull request may close these issues.

10 participants

@sanposhiho @dipesh-rawat @tengqm @k8s-ci-robot @Vyom-Yadav @drewhagen @hacktivist123 @Princesso @Huang-Wei @sftim