fix: resolve gocritic unlambda and formatting issues

Author: SoumyaRaikwar

internal/store/deployment.go

@@ -332,9 +332,7 @@ func deploymentMetricFamilies(allowAnnotationsList, allowLabelsList []string) []
 			metric.Gauge,
 			basemetrics.ALPHA,
 			"",
-			wrapDeploymentFunc(func(d *v1.Deployment) *metric.Family {
-				return generateDeploymentAffinityMetrics(d)
-			}),
+			wrapDeploymentFunc(generateDeploymentAffinityMetrics),
 		),
 
 		*generator.NewFamilyGeneratorWithStability(

internal/store/deployment_test.go

@@ -30,15 +30,15 @@ import (
 
 var (
 	depl1Replicas int32 = 200
-	depl2Replicas int32 = 5
-	depl3Replicas int32 = 1
+	depl2Replicas int32 = 5 
+	depl3Replicas int32 = 1 
 	depl4Replicas int32 = 10
 
 	depl1MaxUnavailable = intstr.FromInt(10)
 	depl2MaxUnavailable = intstr.FromString("25%")
 
 	depl1MaxSurge = intstr.FromInt(10)
-	depl2MaxSurge = intstr.FromString("20%")
+	depl2MaxSurge = intstr.FromString("20%") 
 )
 
 func TestDeploymentStore(t *testing.T) {