-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-5142: Pop pod from backoffQ when activeQ is empty #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 15 commits into
kubernetes:master
from
macsko:pop-Pod_from_backoffq_when-activeq_is_empty
Feb 12, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
58bc648
KEP-5142: Pop pod from backoffQ when activeQ is empty
macsko d2fc2db
Fill all todos and elaborate on some points
macsko e7ebadc
Apply comments
macsko 98c5024
Fix event name
macsko a205b3e
Update toc
macsko afc3295
Improve wording, change target to beta
macsko 259cf07
Update toc
macsko 57bd202
Fix nits, add a part about ordering
macsko f2096df
Fix typo and formatting
macsko bc40cb2
Fix formatting
macsko 1572942
Fix ordering func
macsko 92a64d8
Update toc
macsko 4f21ed3
Update wording
macsko 46219c4
Change stage to beta in prod-readiness
macsko de711ee
Apply review comments
macsko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| kep-number: 5142 | ||
| beta: | ||
| approver: "@wojtek-t" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @wojtek-t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack - waiting for sig buy-in (the PRR is looking good enough, I'm just not sure I understand the change itself - see my comment below).