Skip to content

Conversation

@rata
Copy link
Member

@rata rata commented Feb 6, 2025

This just updates to the new KEP template and check the documentation and design doc boxes we have done for a long time already.

cc @haircommander @mrunalp @giuseppe

  • One-line PR description: Update the KEP template and check some boxes (documentation and design doc) we have done for years now
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2025
@rata rata mentioned this pull request Feb 6, 2025
49 tasks
@rata rata changed the title KEP-127: Update KEP template to latest KEP-127: Update userns KEP template to latest Feb 6, 2025
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@kannon92
Copy link
Contributor

kannon92 commented Feb 6, 2025

I think you still need more items to fill out.

Release Signoff Checklist is missing subbullets for Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) and Graduation criteria is in place
Missing response for Risks and Mitigations
Missing response for Prerequisite testing updates
Missing response for What steps should be taken if SLOs are not being met to determine the problem?
No Drawbacks but this is not vital

@rata
Copy link
Member Author

rata commented Feb 6, 2025

@kannon92 thanks for the review!

Release Signoff Checklist is missing subbullets for Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) and Graduation criteria is in place

It is added on this PR.

Missing response for Risks and Mitigations
Missing response for Prerequisite testing updates

Will add, thanks!

Missing response for What steps should be taken if SLOs are not being met to determine the problem?

This is needed for GA the comments on the template say. I can't link to that part, as the markdown comment can only be seen with the raw file, but here is what it says:

> 
<!--
This section must be completed when targeting beta to a release.

For GA, this section is required: approvers should be able to confirm the
previous answers based on experience in the field.

The Troubleshooting section currently serves the `Playbook` role. We may consider
splitting it into a dedicated `Playbook` document (potentially with some monitoring
details). For now, we leave it here.
-->

We are not targetting GA, so I'm not planning to add this. Or am I missing something?

EDIT: oh, I now see it should be filled for beta but it is required for GA. I can sketch something, but is it required or not, then?

@rata
Copy link
Member Author

rata commented Feb 6, 2025

Okay, I've been doing some digging and I know how to fill that part that part. So I'll fill it up now, and continue with the rest. Thanks!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2025
@rata rata changed the title KEP-127: Update userns KEP template to latest KEP-127: Update userns KEP template to latest and and answer more sections Feb 7, 2025
rata added 3 commits February 7, 2025 15:13
We have documentation published for years. We have also shared the
design in mailing list and sig-node meetings. So, let's check those
boxes.

Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
@rata
Copy link
Member Author

rata commented Feb 7, 2025

Pushed new version with those sections. PTAL!

cc @haircommander :)

@kannon92
Copy link
Contributor

kannon92 commented Feb 7, 2025

Thank you for the updates.

It would be worth answering these questions from an admin standpoint.

https://github.com/kubernetes/enhancements/blob/72fffde58403123c4ac6ac3c689f05edbdd1668a/keps/sig-node/127-user-namespaces/README.md#monitoring-requirements

Given the interest in user namespaces, the answer seems to focus on user workloads and not really answering the question on how an operator would actually know if people are using this feature. Remember there can be many namespaces and an operator would most likely look at metrics to see this info. They would probably not look at each and every pod spec.

I am bringing it up here as we start moving usernamespace to feature gate on we should think through these questions as it does get harder to change as more people start using usernamespaces.

@wojtek-t
Copy link
Member

/lgtm
From PRR perspective

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@rata
Copy link
Member Author

rata commented Feb 10, 2025

@wojtek-t great, thanks!

@kannon92 Feel free to reach out to me on the k8s slack, I'm rata there too. We can talk about it and see if there is something we can agree on. Also, adding a metric is not something hard to change, so I don't think there is urgency to do it for this release.

@haircommander I guess this still LGTY? The deadline is quite close, it would be great to merge this :-)

@haircommander
Copy link
Contributor

yeah still
/lgtm
I agree let's think about metrics but we don't need to address here right now

@rata
Copy link
Member Author

rata commented Feb 11, 2025

@mrunalp @haircommander the KEP is at risk because this PR is not merged. It will be great to merge ASAP

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit d4226c4 into kubernetes:master Feb 11, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants