-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-127: Update userns KEP template to latest and and answer more sections #5141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/lgtm |
|
I think you still need more items to fill out. Release Signoff Checklist is missing subbullets for Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) and Graduation criteria is in place |
|
@kannon92 thanks for the review!
It is added on this PR.
Will add, thanks!
This is needed for GA the comments on the template say. I can't link to that part, as the markdown comment can only be seen with the raw file, but here is what it says: We are not targetting GA, so I'm not planning to add this. Or am I missing something? EDIT: oh, I now see it should be filled for beta but it is required for GA. I can sketch something, but is it required or not, then? |
|
Okay, I've been doing some digging and I know how to fill that part that part. So I'll fill it up now, and continue with the rest. Thanks! |
Signed-off-by: Rodrigo Campos <[email protected]>
We have documentation published for years. We have also shared the design in mailing list and sig-node meetings. So, let's check those boxes. Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
|
Pushed new version with those sections. PTAL! cc @haircommander :) |
|
Thank you for the updates. It would be worth answering these questions from an admin standpoint. Given the interest in user namespaces, the answer seems to focus on user workloads and not really answering the question on how an operator would actually know if people are using this feature. Remember there can be many namespaces and an operator would most likely look at metrics to see this info. They would probably not look at each and every pod spec. I am bringing it up here as we start moving usernamespace to feature gate on we should think through these questions as it does get harder to change as more people start using usernamespaces. |
|
/lgtm |
|
@wojtek-t great, thanks! @kannon92 Feel free to reach out to me on the k8s slack, I'm rata there too. We can talk about it and see if there is something we can agree on. Also, adding a metric is not something hard to change, so I don't think there is urgency to do it for this release. @haircommander I guess this still LGTY? The deadline is quite close, it would be great to merge this :-) |
|
yeah still |
|
@mrunalp @haircommander the KEP is at risk because this PR is not merged. It will be great to merge ASAP |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, rata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This just updates to the new KEP template and check the documentation and design doc boxes we have done for a long time already.
cc @haircommander @mrunalp @giuseppe