Skip to content

Commit 97fd057

Browse files
committed
Add the possibility of increasing consumed resources
Signed-off-by: Yuki Iwai <[email protected]>
1 parent 217adef commit 97fd057

File tree

1 file changed

+9
-4
lines changed
  • keps/sig-apps/3998-job-success-completion-policy

1 file changed

+9
-4
lines changed

keps/sig-apps/3998-job-success-completion-policy/README.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
- [Hold succeededIndexes as []int typed in successPolicy](#hold-succeededindexes-as-int-typed-in-successpolicy)
4848
- [Acceptable percentage of total succeeded indexes in the succeededCount field](#acceptable-percentage-of-total-succeeded-indexes-in-the-succeededcount-field)
4949
- [Match succeededIndexes using CEL](#match-succeededindexes-using-cel)
50-
- [Use JobSet instead of Indexes Job](#use-jobset-instead-of-indexes-job)
50+
- [Use JobSet instead of Indexed Job](#use-jobset-instead-of-indexed-job)
5151
- [Possibility for the lingering pods to continue running after the job meets the successPolicy](#possibility-for-the-lingering-pods-to-continue-running-after-the-job-meets-the-successpolicy)
5252
- [Additional Story](#additional-story)
5353
- [Job API](#job-api-1)
@@ -223,7 +223,7 @@ we probably can not evaluate the SuccessPolicy correctly.
223223

224224
- If we allow to set unlimited size of the value in `.spec.successPolicy.criteria.succeededIndexes`,
225225
we have a risk similar to [KEP-3850: Backoff Limits Per Index For Indexed Jobs](https://github.com/kubernetes/enhancements/tree/76dcd4f342cc0388feb085e685d4cc018ebe1dc9/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs#risks-and-mitigations).
226-
So, we limit the size of `succeededIndexes` to 64Ki.
226+
So, we limit the size of `succeededIndexes` to 64KiB.
227227

228228
## Design Details
229229

@@ -559,6 +559,9 @@ No.
559559

560560
###### Will enabling / using this feature result in any new API calls?
561561

562+
Yes, if the Job meets the SuccessPolicy,
563+
the job-controller must make an additional API call to update the condition with `SuccessCriteriaMet`.
564+
562565
No.
563566

564567
###### Will enabling / using this feature result in introducing new API types?
@@ -583,7 +586,9 @@ No.
583586

584587
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
585588

586-
No.
589+
Yes, the job-controller will consume more CPU and memory to compute the set of indexes from the `succeededIndexes`.
590+
Especially, if there are many of them (approaching the maximum size of them, 64KiB),
591+
the consumed resources might be non-negligible.
587592

588593
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
589594

@@ -702,7 +707,7 @@ type SuccessPolicyCriterion struct {
702707
}
703708
```
704709

705-
### Use JobSet instead of Indexes Job
710+
### Use JobSet instead of Indexed Job
706711

707712
The [JobSet](https://github.com/kubernetes-sigs/jobset) is a custom resource for managing a group of Job as a unit.
708713

0 commit comments

Comments
 (0)