|
47 | 47 | - [Hold succeededIndexes as []int typed in successPolicy](#hold-succeededindexes-as-int-typed-in-successpolicy) |
48 | 48 | - [Acceptable percentage of total succeeded indexes in the succeededCount field](#acceptable-percentage-of-total-succeeded-indexes-in-the-succeededcount-field) |
49 | 49 | - [Match succeededIndexes using CEL](#match-succeededindexes-using-cel) |
50 | | - - [Use JobSet instead of Indexes Job](#use-jobset-instead-of-indexes-job) |
| 50 | + - [Use JobSet instead of Indexed Job](#use-jobset-instead-of-indexed-job) |
51 | 51 | - [Possibility for the lingering pods to continue running after the job meets the successPolicy](#possibility-for-the-lingering-pods-to-continue-running-after-the-job-meets-the-successpolicy) |
52 | 52 | - [Additional Story](#additional-story) |
53 | 53 | - [Job API](#job-api-1) |
@@ -223,7 +223,7 @@ we probably can not evaluate the SuccessPolicy correctly. |
223 | 223 |
|
224 | 224 | - If we allow to set unlimited size of the value in `.spec.successPolicy.criteria.succeededIndexes`, |
225 | 225 | we have a risk similar to [KEP-3850: Backoff Limits Per Index For Indexed Jobs](https://github.com/kubernetes/enhancements/tree/76dcd4f342cc0388feb085e685d4cc018ebe1dc9/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs#risks-and-mitigations). |
226 | | -So, we limit the size of `succeededIndexes` to 64Ki. |
| 226 | +So, we limit the size of `succeededIndexes` to 64KiB. |
227 | 227 |
|
228 | 228 | ## Design Details |
229 | 229 |
|
|
559 | 559 |
|
560 | 560 | ###### Will enabling / using this feature result in any new API calls? |
561 | 561 |
|
| 562 | +Yes, if the Job meets the SuccessPolicy, |
| 563 | +the job-controller must make an additional API call to update the condition with `SuccessCriteriaMet`. |
| 564 | + |
562 | 565 | No. |
563 | 566 |
|
564 | 567 | ###### Will enabling / using this feature result in introducing new API types? |
|
583 | 586 |
|
584 | 587 | ###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components? |
585 | 588 |
|
586 | | -No. |
| 589 | +Yes, the job-controller will consume more CPU and memory to compute the set of indexes from the `succeededIndexes`. |
| 590 | +Especially, if there are many of them (approaching the maximum size of them, 64KiB), |
| 591 | +the consumed resources might be non-negligible. |
587 | 592 |
|
588 | 593 | ###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? |
589 | 594 |
|
@@ -702,7 +707,7 @@ type SuccessPolicyCriterion struct { |
702 | 707 | } |
703 | 708 | ``` |
704 | 709 |
|
705 | | -### Use JobSet instead of Indexes Job |
| 710 | +### Use JobSet instead of Indexed Job |
706 | 711 |
|
707 | 712 | The [JobSet](https://github.com/kubernetes-sigs/jobset) is a custom resource for managing a group of Job as a unit. |
708 | 713 |
|
|
0 commit comments