Skip to content

Commit 4439f98

Browse files
sig-cli: graduate kubectl subresource support to GA
Signed-off-by: Madhav Jivrajani <[email protected]>
1 parent 26c7e13 commit 4439f98

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

keps/prod-readiness/sig-cli/2590.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ kep-number: 2590
22
alpha:
33
approver: "@johnbelamaric"
44
beta:
5+
approver: "@johnbelamaric"
6+
stable:
57
approver: "@johnbelamaric"

keps/sig-cli/2590-kubectl-subresource/README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,8 @@ to implement this enhancement.
220220

221221
##### e2e tests
222222

223+
- e2e test added: [link to test](https://github.com/kubernetes/kubernetes/blob/11b974043604f5ccbeb6e5e62e1d9edcf00bc336/test/e2e/kubectl/kubectl.go#L2101)
224+
223225
### Graduation Criteria
224226

225227
#### Alpha
@@ -234,7 +236,11 @@ to implement this enhancement.
234236

235237
#### GA
236238

237-
- User feedback gathered for at least 1 cycle.
239+
Since v1.27 when the feature moved to beta, there have been no reported bugs concerning this feature.
240+
In fact, it is reassuring to see the community use this feature quite commonly such as in bug reports:
241+
https://github.com/kubernetes/kubernetes/issues/116311
242+
243+
Seeing this and given our added unit, integration and e2e tests gives us the confidence to graduate to GA.
238244

239245

240246
### Upgrade / Downgrade Strategy
@@ -408,6 +414,8 @@ N/A
408414
2021-04-06: KEP proposed
409415
2021-04-07: [Demo] in SIG CLI meeting
410416
2022-05-25: PR for alpha implementation merged
417+
2023-01-12: KEP graduated to Beta
418+
2023-03-15: e2e test added for KEP as part of beta graduation
411419

412420
[POC PR]: https://github.com/kubernetes/kubernetes/pull/99556
413421
[Demo]: https://youtu.be/zUa7dudYCQM?t=299

keps/sig-cli/2590-kubectl-subresource/kep.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,14 @@ approvers:
1212
- "@soltysh"
1313

1414
creation-date: 2021-04-06
15-
last-updated: 2023-01-12
15+
last-updated: 2024-02-01
1616

17-
status: implementable
18-
stage: beta
17+
status: implemented
18+
stage: stable
1919

20-
latest-milestone: "v1.27"
20+
latest-milestone: "v1.30"
2121

2222
milestone:
2323
alpha: "v1.24"
2424
beta: "v1.27"
25+
stable: "v1.30"

0 commit comments

Comments
 (0)