Skip to content

Commit 8ad172a

Browse files
Merge pull request #102966 from SergeyKanzhelev/deprecateDynamicKubeletConfig
deprecate and disable by default DynamicKubeletConfig feature flag Kubernetes-commit: 8e56a3419572b066e11d8ce33eee443ee3317e77
2 parents c712065 + bb601f1 commit 8ad172a

File tree

5 files changed

+18
-11
lines changed

5 files changed

+18
-11
lines changed

core/v1/generated.proto

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/v1/types.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4621,8 +4621,10 @@ type NodeSpec struct {
46214621
// If specified, the node's taints.
46224622
// +optional
46234623
Taints []Taint `json:"taints,omitempty" protobuf:"bytes,5,opt,name=taints"`
4624-
// If specified, the source to get node configuration from
4625-
// The DynamicKubeletConfig feature gate must be enabled for the Kubelet to use this field
4624+
4625+
// Deprecated. If specified, the source of the node's configuration.
4626+
// The DynamicKubeletConfig feature gate must be enabled for the Kubelet to use this field.
4627+
// This field is deprecated as of 1.22: https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration
46264628
// +optional
46274629
ConfigSource *NodeConfigSource `json:"configSource,omitempty" protobuf:"bytes,6,opt,name=configSource"`
46284630

@@ -4633,6 +4635,7 @@ type NodeSpec struct {
46334635
}
46344636

46354637
// NodeConfigSource specifies a source of node configuration. Exactly one subfield (excluding metadata) must be non-nil.
4638+
// This API is deprecated since 1.22
46364639
type NodeConfigSource struct {
46374640
// For historical context, regarding the below kind, apiVersion, and configMapRef deprecation tags:
46384641
// 1. kind/apiVersion were used by the kubelet to persist this struct to disk (they had no protobuf tags)
@@ -4650,6 +4653,7 @@ type NodeConfigSource struct {
46504653
}
46514654

46524655
// ConfigMapNodeConfigSource contains the information to reference a ConfigMap as a config source for the Node.
4656+
// This API is deprecated since 1.22: https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration
46534657
type ConfigMapNodeConfigSource struct {
46544658
// Namespace is the metadata.namespace of the referenced ConfigMap.
46554659
// This field is required in all cases.

core/v1/types_swagger_doc_generated.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ func (ConfigMapList) SwaggerDoc() map[string]string {
291291
}
292292

293293
var map_ConfigMapNodeConfigSource = map[string]string{
294-
"": "ConfigMapNodeConfigSource contains the information to reference a ConfigMap as a config source for the Node.",
294+
"": "ConfigMapNodeConfigSource contains the information to reference a ConfigMap as a config source for the Node. This API is deprecated since 1.22: https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration",
295295
"namespace": "Namespace is the metadata.namespace of the referenced ConfigMap. This field is required in all cases.",
296296
"name": "Name is the metadata.name of the referenced ConfigMap. This field is required in all cases.",
297297
"uid": "UID is the metadata.UID of the referenced ConfigMap. This field is forbidden in Node.Spec, and required in Node.Status.",
@@ -1085,7 +1085,7 @@ func (NodeCondition) SwaggerDoc() map[string]string {
10851085
}
10861086

10871087
var map_NodeConfigSource = map[string]string{
1088-
"": "NodeConfigSource specifies a source of node configuration. Exactly one subfield (excluding metadata) must be non-nil.",
1088+
"": "NodeConfigSource specifies a source of node configuration. Exactly one subfield (excluding metadata) must be non-nil. This API is deprecated since 1.22",
10891089
"configMap": "ConfigMap is a reference to a Node's ConfigMap",
10901090
}
10911091

@@ -1179,7 +1179,7 @@ var map_NodeSpec = map[string]string{
11791179
"providerID": "ID of the node assigned by the cloud provider in the format: <ProviderName>://<ProviderSpecificNodeID>",
11801180
"unschedulable": "Unschedulable controls node schedulability of new pods. By default, node is schedulable. More info: https://kubernetes.io/docs/concepts/nodes/node/#manual-node-administration",
11811181
"taints": "If specified, the node's taints.",
1182-
"configSource": "If specified, the source to get node configuration from The DynamicKubeletConfig feature gate must be enabled for the Kubelet to use this field",
1182+
"configSource": "Deprecated. If specified, the source of the node's configuration. The DynamicKubeletConfig feature gate must be enabled for the Kubelet to use this field. This field is deprecated as of 1.22: https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration",
11831183
"externalID": "Deprecated. Not all kubelets will set this field. Remove field after 1.13. see: https://issues.k8s.io/61966",
11841184
}
11851185

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ go 1.16
77
require (
88
github.com/gogo/protobuf v1.3.2
99
github.com/stretchr/testify v1.7.0
10-
k8s.io/apimachinery v0.0.0-20210701054147-830375057167
10+
k8s.io/apimachinery v0.0.0-20210708014216-0dafcb48b31e
1111
)
1212

13-
replace k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20210701054147-830375057167
13+
replace k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20210708014216-0dafcb48b31e

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v
207207
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
208208
honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
209209
honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
210-
k8s.io/apimachinery v0.0.0-20210701054147-830375057167 h1:fob/j8+uMBIVvyo+9bG7GvjFSj0LX3RNuSXW+RcUrwo=
211-
k8s.io/apimachinery v0.0.0-20210701054147-830375057167/go.mod h1:O3oNtNadZdeOMxHFVxOreoznohCpy0z6mocxbZr7oJ0=
210+
k8s.io/apimachinery v0.0.0-20210708014216-0dafcb48b31e h1:EZ+ZrcPtnkR8vVo7bBSwoMD9a0HaC29O6lJhcZgwsJQ=
211+
k8s.io/apimachinery v0.0.0-20210708014216-0dafcb48b31e/go.mod h1:O3oNtNadZdeOMxHFVxOreoznohCpy0z6mocxbZr7oJ0=
212212
k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
213213
k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE=
214214
k8s.io/klog/v2 v2.9.0 h1:D7HV+n1V57XeZ0m6tdRkfknthUaM06VFbWldOFh8kzM=

0 commit comments

Comments
 (0)