Clarify Gateway Listener Distinct definitions #3477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
youngnick
force-pushed
the
distinct-listener-update
branch
5 times, most recently
from
3c5c90c to
5918d70
Compare
robscott
reviewed
Dec 2, 2024
Signed-off-by: Nick Young <[email protected]>
youngnick
force-pushed
the
distinct-listener-update
branch
from
5918d70 to
8a2a553
Compare
k8s-ci-robot
added
size/L
mlavacca
reviewed
Dec 3, 2024
robscott
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks @youngnick! This is a great set of improvements! As I mentioned in today's community meeting, I'll defer on merging this until Friday to give everyone a chance to review.
/hold
Comment on lines
+166
to
+169
| // * The implementation MUST NOT pick one conflicting Listener as the winner. | ||
| // ALL indistinct Listeners must not be accepted for processing. | ||
| // * At least one distinct Listener MUST be present, or else the Gateway effectively | ||
| // contains _no_ Listeners, and must be rejected from processing as a whole. |
There was a problem hiding this comment.
This seems like something that would be fairly easy to write a conformance test for. Once this merges, we should file a follow up issue for this.
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, robscott, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
youngnick
force-pushed
the
distinct-listener-update
branch
from
fb2d263 to
19dbede
Compare
youngnick
commented
Dec 5, 2024
youngnick
force-pushed
the
distinct-listener-update
branch
from
19dbede to
29fc5f9
Compare
bjee19
reviewed
Dec 9, 2024
|
Soak time has passed, will LGTM once the comment above is resolved. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Nick Young <[email protected]>
youngnick
force-pushed
the
distinct-listener-update
branch
from
29fc5f9 to
d29c8dd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the Listener godocs to clarify:
Updates #3297
Does this PR introduce a user-facing change?: