Skip to content

Commit fcf09f2

Browse files
committed
Gateway API docs updated
The ListenerReasonRefNotPermitted documentation has been improved to specify that this reason can be triggered by either an unpermitted BackendRef or an unpermitted CertificateRef. Besides, the ListenerReasonInvalidCertificateRef documentation has been improved to specify better what makes a listener CertificateRef invalid. Signed-off-by: Mattia Lavacca <[email protected]>
1 parent 2738bba commit fcf09f2

File tree

2 files changed

+24
-10
lines changed

2 files changed

+24
-10
lines changed

apis/v1alpha2/gateway_types.go

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -397,17 +397,24 @@ const (
397397

398398
// This reason is used with the "ResolvedRefs" condition when the
399399
// Listener has a TLS configuration with at least one TLS CertificateRef
400-
// that is invalid or cannot be resolved.
400+
// that is invalid or does not exist.
401+
// A CertificateRef is considered invalid when it refers to a nonexistent
402+
// or unsupported resource or kind, or when the data within that resource
403+
// is malformed.
404+
// This reason must be used only when the reference is granted, which means
405+
// that if the referenced secret is invalid or does not exist, but the
406+
// reference is not allowed because of the lack of a ReferenceGrant, the
407+
// reason RefNotPermitted must be used.
401408
ListenerReasonInvalidCertificateRef ListenerConditionReason = "InvalidCertificateRef"
402409

403410
// This reason is used with the "ResolvedRefs" condition when an invalid or
404411
// unsupported Route kind is specified by the Listener.
405412
ListenerReasonInvalidRouteKinds ListenerConditionReason = "InvalidRouteKinds"
406413

407-
// This reason is used with the "ResolvedRefs" condition when
408-
// one of the Listener's Routes has a BackendRef to an object in
409-
// another namespace, where the object in the other namespace does
410-
// not have a ReferenceGrant explicitly allowing the reference.
414+
// This reason is used with the "ResolvedRefs" condition when the
415+
// Listener has a TLS configuration that references an object in another
416+
// namespace, where the object in the other namespace does not have a
417+
// ReferenceGrant explicitly allowing the reference.
411418
ListenerReasonRefNotPermitted ListenerConditionReason = "RefNotPermitted"
412419
)
413420

apis/v1beta1/gateway_types.go

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -747,17 +747,24 @@ const (
747747

748748
// This reason is used with the "ResolvedRefs" condition when the
749749
// Listener has a TLS configuration with at least one TLS CertificateRef
750-
// that is invalid or cannot be resolved.
750+
// that is invalid or does not exist.
751+
// A CertificateRef is considered invalid when it refers to a nonexistent
752+
// or unsupported resource or kind, or when the data within that resource
753+
// is malformed.
754+
// This reason must be used only when the reference is granted, which means
755+
// that if the referenced secret is invalid or does not exist, but the
756+
// reference is not allowed because of the lack of a ReferenceGrant, the
757+
// reason RefNotPermitted must be used.
751758
ListenerReasonInvalidCertificateRef ListenerConditionReason = "InvalidCertificateRef"
752759

753760
// This reason is used with the "ResolvedRefs" condition when an invalid or
754761
// unsupported Route kind is specified by the Listener.
755762
ListenerReasonInvalidRouteKinds ListenerConditionReason = "InvalidRouteKinds"
756763

757-
// This reason is used with the "ResolvedRefs" condition when
758-
// one of the Listener's Routes has a BackendRef to an object in
759-
// another namespace, where the object in the other namespace does
760-
// not have a ReferenceGrant explicitly allowing the reference.
764+
// This reason is used with the "ResolvedRefs" condition when the
765+
// Listener has a TLS configuration that references an object in another
766+
// namespace, where the object in the other namespace does not have a
767+
// ReferenceGrant explicitly allowing the reference.
761768
ListenerReasonRefNotPermitted ListenerConditionReason = "RefNotPermitted"
762769
)
763770

0 commit comments

Comments
 (0)