modernize for loops

Author: HaraldNordgren

.github/workflows/golangci-lint.yml

@@ -33,6 +33,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # tag=v8.0.0
         with:
-          version: v2.5.0
+          version: v2.6.0
           args: --output.text.print-linter-name=true --output.text.colors=true --timeout 10m
           working-directory: ${{matrix.working-directory}}

.golangci.yml

@@ -32,6 +32,7 @@ linters:
     - iotamixing
     - makezero
     - misspell
+    - modernize
     - nakedret
     - nilerr
     - nolintlint

pkg/genall/help/pretty/print.go

@@ -291,7 +291,7 @@ func writePadding(out io.Writer, typ []byte, amt int) error {
 
 	num := amt / len(typ)
 	rem := amt % len(typ)
-	for i := 0; i < num; i++ {
+	for range num {
 		if _, err := out.Write(typ); err != nil {
 			return err
 		}

pkg/rbac/parser_integration_test.go

@@ -19,7 +19,7 @@ import (
 var _ = Describe("ClusterRole generated by the RBAC Generator", func() {
 	// run this test multiple times to make sure the Rule order is stable.
 	const stableTestCount = 5
-	for i := 0; i < stableTestCount; i++ {
+	for range stableTestCount {
 		It("should match the expected result", func() {
 			By("switching into testdata to appease go modules")
 			cwd, err := os.Getwd()

pkg/webhook/parser_integration_test.go

@@ -276,7 +276,7 @@ var _ = Describe("Webhook Generation From Parsing to CustomResourceDefinition",
 		Expect(err).NotTo(HaveOccurred())
 		defer os.RemoveAll(outputDir)
 
-		for i := 0; i < 10; i++ {
+		for range 10 {
 			genCtx := &genall.GenerationContext{
 				Collector:  &markers.Collector{Registry: reg},
 				Roots:      pkgs,