🏃 removed the error message checking from the tests

Author: droot

pkg/conversion/conversion.go

@@ -16,7 +16,7 @@ limitations under the License.
 
 /*
 Package conversion provides interface definitions that an API Type needs to
-implement in order to be supported by the generic conversion webhook handler
+implement for it to be supported by the generic conversion webhook handler
 defined under pkg/webhook/conversion.
 */
 package conversion

pkg/webhook/conversion/conversion.go

@@ -17,7 +17,7 @@ limitations under the License.
 /*
 Package conversion provides implementation for CRD conversion webhook that implements handler for version conversion requests for types that are convertible.
 
-See pkg/conversion for interface definitions required to ensure a Type is convertible.
+See pkg/conversion for interface definitions required to ensure an API Type is convertible.
 */
 package conversion
 

pkg/webhook/conversion/conversion_test.go

@@ -145,8 +145,7 @@ var _ = Describe("Conversion Webhook", func() {
 		}
 
 		convReview := doRequest(convReq)
-		Expect(convReview.Response.Result.Message).Should(
-			ContainSubstring(`no kind "ExternalJob" is registered for version`))
+		Expect(convReview.Response.Result.Status).To(Equal("Failure"))
 		Expect(convReview.Response.ConvertedObjects).Should(BeEmpty())
 	})
 
@@ -167,9 +166,7 @@ var _ = Describe("Conversion Webhook", func() {
 		}
 
 		convReview := doRequest(convReq)
-
-		Expect(convReview.Response.Result.Message).To(
-			Equal("conversion is not allowed between same type *v1.ExternalJob"))
+		Expect(convReview.Response.Result.Status).To(Equal("Failure"))
 		Expect(convReview.Response.ConvertedObjects).Should(BeEmpty())
 	})
 
@@ -199,9 +196,7 @@ var _ = Describe("Conversion Webhook", func() {
 		}
 
 		convReview := doRequest(convReq)
-
-		Expect(convReview.Response.Result.Message).To(
-			Equal("*v1beta1.Deployment is not convertible to *v1.Deployment"))
+		Expect(convReview.Response.Result.Status).To(Equal("Failure"))
 		Expect(convReview.Response.ConvertedObjects).Should(BeEmpty())
 	})