Revert renaming of GetEventRecorderFor

Signed-off-by: Borja Clemente <[email protected]>

Author: clebs

designs/move-cluster-specific-code-out-of-manager.md

@@ -61,8 +61,8 @@ type Cluster interface {
 	// GetCache returns a cache.Cache
 	GetCache() cache.Cache
 
-	//GetEventRecorder returns a new EventRecorder for the provided name
-	GetEventRecorder(name string) record.EventRecorder
+	// GetEventRecorderFor returns a new EventRecorder for the provided name
+	GetEventRecorderFor(name string) record.EventRecorder
 
 	// GetRESTMapper returns a RESTMapper
 	GetRESTMapper() meta.RESTMapper

pkg/cluster/cluster_test.go

@@ -157,7 +157,7 @@ var _ = Describe("cluster.Cluster", func() {
 	It("should provide a function to get the EventRecorder", func() {
 		c, err := New(cfg)
 		Expect(err).NotTo(HaveOccurred())
-		Expect(c.GetEventRecorder("test")).NotTo(BeNil())
+		Expect(c.GetEventRecorderFor("test")).NotTo(BeNil())
 	})
 	It("should provide a function to get the APIReader", func() {
 		c, err := New(cfg)

pkg/cluster/internal.go

@@ -84,8 +84,8 @@ func (c *cluster) GetCache() cache.Cache {
 	return c.cache
 }
 
-func (c *cluster) GetEventRecorder(name string) events.EventRecorder {
-	return c.recorderProvider.GetEventRecorder(name)
+func (c *cluster) GetEventRecorderFor(name string) events.EventRecorder {
+	return c.recorderProvider.GetEventRecorderFor(name)
 }
 
 func (c *cluster) GetOldEventRecorder(name string) record.EventRecorder {

pkg/internal/recorder/recorder.go

@@ -133,9 +133,9 @@ func NewProvider(config *rest.Config, httpClient *http.Client, scheme *runtime.S
 	return p, nil
 }
 
-// GetEventRecorder returns an event recorder that broadcasts to this provider's
+// GetEventRecorderFor returns an event recorder that broadcasts to this provider's
 // broadcaster.  All events will be associated with a component of the given name.
-func (p *Provider) GetEventRecorder(name string) events.EventRecorder {
+func (p *Provider) GetEventRecorderFor(name string) events.EventRecorder {
 	return &lazyRecorder{
 		prov: p,
 		name: name,

pkg/internal/recorder/recorder_integration_test.go

@@ -43,7 +43,7 @@ var _ = Describe("recorder", func() {
 			Expect(err).NotTo(HaveOccurred())
 
 			By("Creating the Controller")
-			recorder := cm.GetEventRecorder("test-recorder")
+			recorder := cm.GetEventRecorderFor("test-recorder")
 			instance, err := controller.New("foo-controller", cm, controller.Options{
 				Reconciler: reconcile.Func(
 					func(ctx context.Context, request reconcile.Request) (reconcile.Result, error) {

pkg/internal/recorder/recorder_test.go

@@ -43,12 +43,12 @@ var _ = Describe("recorder.Provider", func() {
 			Expect(err.Error()).To(ContainSubstring("failed to init client"))
 		})
 	})
-	Describe("GetEventRecorder", func() {
+	Describe("GetEventRecorderFor", func() {
 		It("should return a recorder instance.", func() {
 			provider, err := recorder.NewProvider(cfg, httpClient, scheme.Scheme, logr.Discard(), makeBroadcaster)
 			Expect(err).NotTo(HaveOccurred())
 
-			recorder := provider.GetEventRecorder("test")
+			recorder := provider.GetEventRecorderFor("test")
 			Expect(recorder).NotTo(BeNil())
 		})
 	})

pkg/manager/internal.go

@@ -256,8 +256,8 @@ func (cm *controllerManager) GetCache() cache.Cache {
 	return cm.cluster.GetCache()
 }
 
-func (cm *controllerManager) GetEventRecorder(name string) events.EventRecorder {
-	return cm.cluster.GetEventRecorder(name)
+func (cm *controllerManager) GetEventRecorderFor(name string) events.EventRecorder {
+	return cm.cluster.GetEventRecorderFor(name)
 }
 
 func (cm *controllerManager) GetOldEventRecorder(name string) record.EventRecorder {

pkg/manager/manager_test.go

@@ -1861,7 +1861,7 @@ var _ = Describe("manger.Manager", func() {
 		ns := corev1.Namespace{}
 		ns.Name = "default"
 
-		recorder := m.GetEventRecorder("rock-and-roll")
+		recorder := m.GetEventRecorderFor("rock-and-roll")
 		Expect(m.Add(RunnableFunc(func(_ context.Context) error {
 			recorder.Event(&ns, "Warning", "BallroomBlitz", "yeah, yeah, yeah-yeah-yeah")
 			return nil
@@ -1934,7 +1934,7 @@ var _ = Describe("manger.Manager", func() {
 	It("should provide a function to get the EventRecorder", func() {
 		m, err := New(cfg, Options{})
 		Expect(err).NotTo(HaveOccurred())
-		Expect(m.GetEventRecorder("test")).NotTo(BeNil())
+		Expect(m.GetEventRecorderFor("test")).NotTo(BeNil())
 	})
 	It("should provide a function to get the APIReader", func() {
 		m, err := New(cfg, Options{})

pkg/recorder/example_test.go

@@ -30,7 +30,7 @@ var (
 
 func Example_event() {
 	// recorderProvider is a recorder.Provider
-	recorder := recorderProvider.GetEventRecorder("my-controller")
+	recorder := recorderProvider.GetEventRecorderFor("my-controller")
 
 	// emit an event with a fixed message
 	recorder.Event(somePod, corev1.EventTypeWarning,
@@ -39,7 +39,7 @@ func Example_event() {
 
 func Example_eventf() {
 	// recorderProvider is a recorder.Provider
-	recorder := recorderProvider.GetEventRecorder("my-controller")
+	recorder := recorderProvider.GetEventRecorderFor("my-controller")
 
 	// emit an event with a variable message
 	mildCheese := "Wensleydale"

pkg/recorder/recorder.go

@@ -28,7 +28,7 @@ import (
 // Provider knows how to generate new event recorders with given name.
 type Provider interface {
 	// NewRecorder returns an EventRecorder with given name.
-	GetEventRecorder(name string) events.EventRecorder
+	GetEventRecorderFor(name string) events.EventRecorder
 	// GetOldEventRecorder returns an EventRecorder for the old events API.
 	// The old API is not 100% supported anymore, use the new one whenever possible.
 	GetOldEventRecorder(name string) record.EventRecorder