⚠️ Add MinReadySeconds to Machine and remove it from MachineDeployment, MachineSet, MachinePool. #12153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinedeployment
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sivchari
changed the title
k8s-ci-robot
added
size/XL
sivchari
force-pushed
the
add-minreadyseconds
branch
2 times, most recently
from
535bbca to
a4cd79e
Compare
Member
Author
|
/area clusterclass |
sivchari
force-pushed
the
add-minreadyseconds
branch
from
a4cd79e to
8466738
Compare
sivchari
changed the title
k8s-ci-robot
added
size/L
sivchari
force-pushed
the
add-minreadyseconds
branch
5 times, most recently
from
13bafcb to
d992b7b
Compare
Member
Author
|
/hold work in progress |
k8s-ci-robot
added
the
do-not-merge/hold
sivchari
force-pushed
the
add-minreadyseconds
branch
from
a9a1946 to
97be584
Compare
k8s-ci-robot
added
size/XL
Member
Author
|
/remove-area clusterclass |
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
add-minreadyseconds
branch
from
daf49d9 to
522e627
Compare
k8s-ci-robot
added
size/L
Member
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
sbueringer
reviewed
May 20, 2025
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Member
Author
|
@sbueringer |
sbueringer
added
the
tide/merge-method-squash
sbueringer
reviewed
May 21, 2025
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 2ed0a9d5e87182fb88d762f8481c8b172188e4ce
|
Member
fabriziopandini
left a comment
fabriziopandini
left a comment
There was a problem hiding this comment.
Great work!
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first task that changes API.
Sorry if I'm making a wrong fix or if I'm making the review process too much of a hassle. You can close this PR if you want, but I'd really appreciate if you could help me with this task.
What this PR does / why we need it:
As a title, added MinReadySeconds to Machine Spec and remove it from MachineDeployment, MachineSet, MachinePool and ClusterClass.
KCP doesn't have it, so I don't touch it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11947
/area machinedeployment
/area machineset
/area machinepool
/area machine