-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 Fix the condition to check whether cluster has v1beta2 conditions #12100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix the condition to check whether cluster has v1beta2 conditions #12100
Conversation
030ff45 to
09792b1
Compare
|
/assign @chrischdi |
Signed-off-by: sivchari <[email protected]>
09792b1 to
06a1bdf
Compare
chrischdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM label has been added. Git tree hash: 7b57c7ed7ed6a392061d3773cba7876c58a8254d
|
|
/test pull-cluster-api-e2e-latestk8s-main |
chrischdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
verifyV1Beta2ConditionsTrueV1Beta1 loops cluster's condition or machines' one to check the state, then, it also loops the cluster.Status.V1Beta2.Conditions, so we need them to have one or more v1beta2 conditions. But currently, we checks if the cluster.Status.V1Beta2.Conditions is nil. Thus this check hasn't confirms the conditions so far. So I fixed the condition to check correctly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11963
/kind bug
/area ci
/area testing