Skip to content

Commit a7c7ba8

Browse files
committed
Overwrite old values correctly, don't cache current resources list
1 parent d86c46a commit a7c7ba8

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

charts/helm-dashboard/README.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
```bash
66
helm repo add komodorio https://helm-charts.komodor.io
77
helm repo update
8-
helm upgrade --install my-release komodorio/helm-dashboard
8+
helm upgrade --install helm-dashboard komodorio/helm-dashboard
99
```
1010

1111
## Introduction
@@ -17,14 +17,13 @@ While installed inside cluster, Helm Dashboard will run some additional backgrou
1717
## Prerequisites
1818

1919
- Kubernetes 1.16+
20-
- Helm 3+
2120

2221
## Installing the Chart
2322

24-
To install the chart with the release name `my-release`:
23+
To install the chart with the release name `helm-dashboard`:
2524

2625
```bash
27-
helm install my-release .
26+
helm install helm-dashboard .
2827
```
2928

3029
The command deploys Helm Dashboard on the Kubernetes cluster in the default configuration. The [Parameters](#parameters) section lists the parameters that can be configured during installation.
@@ -33,10 +32,10 @@ The command deploys Helm Dashboard on the Kubernetes cluster in the default conf
3332
3433
## Uninstalling the Chart
3534

36-
To uninstall/delete the `my-release` deployment:
35+
To uninstall/delete the `helm-dashboard` deployment:
3736

3837
```bash
39-
helm uninstall my-release
38+
helm uninstall helm-dashboard
4039
```
4140

4241
The command removes all the Kubernetes components associated with the chart and deletes the release.
@@ -80,7 +79,7 @@ The following table lists the configurable parameters of the chart and their def
8079
Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.
8180

8281
```bash
83-
helm upgrade --install my-release komodorio/helm-dashboard --set dashboard.allowWriteActions=true --set service.port=9090
82+
helm upgrade --install helm-dashboard komodorio/helm-dashboard --set dashboard.allowWriteActions=true --set service.port=9090
8483
```
8584

8685
> **Tip**: You can use the default [values.yaml](values.yaml)

pkg/dashboard/handlers/helmHandlers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func (h *HelmHandler) History(c *gin.Context) {
121121
}
122122

123123
func (h *HelmHandler) Resources(c *gin.Context) {
124-
h.EnableClientCache(c)
124+
// can't enable the client cache because resource list changes with time
125125

126126
rel := h.getRelease(c)
127127
if rel == nil {

pkg/dashboard/objects/releases.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ func (r *Release) Upgrade(repoChart string, version string, justTemplate bool, v
320320
cmd.Version = version
321321

322322
cmd.DryRun = justTemplate
323+
cmd.ResetValues = true
323324

324325
chrt, err := locateChart(cmd.ChartPathOptions, repoChart, r.Settings)
325326
if err != nil {

0 commit comments

Comments
 (0)