it will conflict when custom model named the same as java.lang.*

[jxnu-liguobin]

Issue Description

1. I want to know how to use custom scalar parsing when parsing JSON without using spring IOC
2. i use graphql interface hava failed:

Cannot construct instance of `io.github.dreamylost.model.Character` (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
 at [Source: (PushbackInputStream); line: 1, column: 17] (through reference chain: io.github.dreamylost.model.HeroQueryResponse["data"]->java.util.LinkedHashMap["hero"])

i use java main method, instance of spring bean，so i create a RestTemplate with new to execute request
this is my client example:

    @Override
    public Character hero(Episode episode) throws Exception {
        HeroQueryRequest heroQueryRequest = new HeroQueryRequest();
        heroQueryRequest.setEpisode(episode);

        CharacterResponseProjection characterResponseProjection = new CharacterResponseProjection();
        characterResponseProjection.id().name().onDroid(new DroidResponseProjection().id().name());

        GraphQLRequest graphQLRequest = new GraphQLRequest(heroQueryRequest, characterResponseProjection);
       //will error， I'm not familiar with this, so i create a issue
        HeroQueryResponse result = Config.restTemplate.exchange(URI.create(Config.productUrl), HttpMethod.POST, Config.httpEntity(graphQLRequest), HeroQueryResponse.class).getBody();

        assert result != null;
        return result.hero();

    }

Steps to Reproduce

List in detail the exact steps to reproduce the unexpected behavior.

Expected Result

Explain in detail what behavior you expected to happen.

Actual Result

Explain in detail what behavior actually happened.

Your Environment and Setup

• graphql-java-codegen: E.g.: 2.2.1
• Build tool: E.g.: SBT
• Java tool: E.g.: Java 8u241
• Mapping Config: E.g.:

import java.util

name := "sbt-codegen-exmaple"

version := "1.0.0-SNAPSHOT"

organization := "io.github.dreamylost"


enablePlugins(GraphQLCodegenPlugin)

libraryDependencies ++= GraphQLCodegen ++ Seq(
  "org.springframework" % "spring-web" % "5.2.7.RELEASE"
) ++  Seq(
  "org.apache.logging.log4j" %% "log4j-api-scala" % "11.0",
  "org.apache.logging.log4j" % "log4j-api" % "2.8.2",
  "org.apache.logging.log4j" % "log4j-core" % "2.8.2",
  "org.apache.logging.log4j" % "log4j-slf4j-impl" % "2.8.2")


graphqlSchemaPaths := Array("src/main/resources/schema.graphqls")
modelPackageName := Some("io.github.dreamylost.model")
apiPackageName := Some("io.github.dreamylost.api")
generateClient := Some(true)
generateApis := Some(true)
customTypesMapping := {
  val mapping = new util.HashMap[String, String]
  mapping.put("Email", "io.github.dreamylost.scalar.EmailScalar")
  mapping
}

Additional context

this is draft impl and example for sbt : https://github.com/jxnu-liguobin/graphql-java-codegen/tree/master/plugins/sbt/graphql-java-codegen-sbt-plugin , but i don't know about GraphQLCodegenConfiguration and if i impl GraphQLCodegenConfiguration, can not use settingKey in override method in sbt, so i do not impl it.

[kobylynskyi]

hi @jxnu-liguobin
I think the issue is in the following part:

Config.httpEntity(graphQLRequest)

Are you using a .toString()? There's a method to properly serialize a GraphQL request:
graphQLRequest.toHttpJsonBody()
Please try this and let me know how it works.

[jxnu-liguobin]

thanks, i have did it,

    public static HttpEntity<String> httpEntity(GraphQLRequest request) {
        HttpHeaders headers = new HttpHeaders();
        headers.setAccept(Collections.singletonList(MediaType.APPLICATION_JSON));
        headers.setContentType(MediaType.APPLICATION_JSON);
        return new HttpEntity<>(request.toHttpJsonBody(), headers);
    }

so request is successfully, but response error when deserializer

[kobylynskyi]

Can you please try setting the property modelNameSuffix?
Just to understand whether the problem is (is not) related to the conflict between class io.github.dreamylost.model.Character and java.lang.Character.

modelNameSuffix will add the suffix to all model classes. In your case the Character class will be generated as io.github.dreamylost.model.CharacterTO (in case modelNameSuffix := "TO")

Thanks!

[jxnu-liguobin]

setting

java code

exception

Although there is no solution,But I think absolute path is a good choice, like protobuf

[jxnu-liguobin]

It may have something to do with Jackson configuration, because I used the default configuration, but the interface has multiple subclasses？i am not sure

[kobylynskyi]

Oh, so Character is interface. I didn't notice from your initial request.
In this case, you need to add __typename to the response projection (using typename()) and create your own serializer which will do the job based on the type of Character (Droid/Human/etc).

[jxnu-liguobin]

but i can not find typename() in CharacterResponseProjection, need some setting?

[kobylynskyi]

Oh, you are right!
So there are two issues:

1. typename() is added only to unions as of now. It should be possible to specify it for interfaces too.
2. Another issue is that customAnnotationsMapping is only supported for field-level and not class-level.

I will implement both of these issues on Friday/Saturday and you should get the build over the weekend.
Plus I will document the approach of writing the serializer.

Thanks again for finding this!

[jxnu-liguobin]

Oh, add typename is very nice，but i think we need customAnnotationsMapping for class-level to impl pagination. beacuse we have did it at my company

[kobylynskyi]

Yes, that's exactly what we need to do.

So that your generated class will be:

@com.fasterxml.jackson.databind.annotation.JsonDeserialize(using = io.github.dreamylost.jackson.CharacterDeserializer.class)
public interface Character {

in case you specified it in your config):

customAnnotationsMapping := {
  val mapping = new util.HashMap[String, String]
  mapping.put("Character", "com.fasterxml.jackson.databind.annotation.JsonDeserialize(using = io.github.dreamylost.jackson.CharacterDeserializer.class)")
  mapping
}

[jxnu-liguobin]

Let me summarize this question

1. customAnnotationsMapping at class-level
2. typename in interface
3. named conflict with java.lang.*

Besides, I would like to ask,can you see the plug-in I implemented? I wonder if I can submit a PR for scala platform(It may not be perfect now, but if can, i will do it continue)

[kobylynskyi]

Created separate issues to track it: #230 and #231
And I don't see any issues with conflicting names: