Skip to content

Commit 69dee51

Browse files
Add serialVersionUID to generated classes that implement Serializable (#811)
Co-authored-by: Bogdan Kobylynskyi <[email protected]> Co-authored-by: Stein Rolevink <[email protected]>
1 parent 964094c commit 69dee51

File tree

61 files changed

+164
-44
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+164
-44
lines changed

plugins/maven/graphql-java-codegen-maven-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<developerConnection>scm:git:[email protected]:kobylynskyi/graphql-java-codegen.git
3737
</developerConnection>
3838
<url>https://github.com/kobylynskyi/graphql-java-codegen/tree/master/plugins/maven</url>
39-
<tag>v5.3.0</tag>
39+
<tag>HEAD</tag>
4040
</scm>
4141

4242
<distributionManagement>

src/main/resources/templates/java-lang/type.ftl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ import java.util.StringJoiner;
3636
</#list>
3737
public class ${className} implements java.io.Serializable<#if implements?has_content><#list implements as interface>, ${interface}<#if interface_has_next></#if></#list></#if> {
3838

39+
private static final long serialVersionUID = 1L;
40+
3941
<#if fields?has_content>
4042
<#list fields as field>
4143
<#if field.deprecated?has_content>

src/test/resources/expected-classes/CommentDeletedEvent.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package com.github.graphql;
77
)
88
public class CommentDeletedEvent implements java.io.Serializable, IssueTimelineItems, PullRequestTimelineItems, Node {
99

10+
private static final long serialVersionUID = 1L;
11+
1012
@javax.validation.constraints.NotNull
1113
private String id;
1214

@@ -48,4 +50,4 @@ public class CommentDeletedEvent implements java.io.Serializable, IssueTimelineI
4850
}
4951

5052
}
51-
}
53+
}

src/test/resources/expected-classes/Commit.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package com.github.graphql;
77
)
88
public class Commit implements java.io.Serializable, Closer, IssueTimelineItem, PullRequestTimelineItem, Subscribable, Node, GitObject, UniformResourceLocatable {
99

10+
private static final long serialVersionUID = 1L;
11+
1012
@javax.validation.constraints.NotNull
1113
private String abbreviatedOid;
1214
private int additions;
@@ -626,4 +628,4 @@ public class Commit implements java.io.Serializable, Closer, IssueTimelineItem,
626628
}
627629

628630
}
629-
}
631+
}

src/test/resources/expected-classes/Commit_noParametrizedFields.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package com.github.graphql;
77
)
88
public class Commit implements java.io.Serializable, Closer, IssueTimelineItem, PullRequestTimelineItem, Subscribable, Node, GitObject, UniformResourceLocatable {
99

10+
private static final long serialVersionUID = 1L;
11+
1012
@javax.validation.constraints.NotNull
1113
private String abbreviatedOid;
1214
private int additions;
@@ -532,4 +534,4 @@ public class Commit implements java.io.Serializable, Closer, IssueTimelineItem,
532534
}
533535

534536
}
535-
}
537+
}

src/test/resources/expected-classes/Commit_noValidationAnnotation.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package com.github.graphql;
77
)
88
public class Commit implements java.io.Serializable, Closer, IssueTimelineItem, PullRequestTimelineItem, Subscribable, Node, GitObject, UniformResourceLocatable {
99

10+
private static final long serialVersionUID = 1L;
11+
1012
private String abbreviatedOid;
1113
private int additions;
1214
private PullRequestConnection associatedPullRequests;
@@ -602,4 +604,4 @@ public class Commit implements java.io.Serializable, Closer, IssueTimelineItem,
602604
}
603605

604606
}
605-
}
607+
}

src/test/resources/expected-classes/Commit_withoutPrimitives.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package com.github.graphql;
77
)
88
public class Commit implements java.io.Serializable, Closer, IssueTimelineItem, PullRequestTimelineItem, Subscribable, Node, GitObject, UniformResourceLocatable {
99

10+
private static final long serialVersionUID = 1L;
11+
1012
@javax.validation.constraints.NotNull
1113
private String abbreviatedOid;
1214
@javax.validation.constraints.NotNull
@@ -632,4 +634,4 @@ public class Commit implements java.io.Serializable, Closer, IssueTimelineItem,
632634
}
633635

634636
}
635-
}
637+
}

src/test/resources/expected-classes/Event.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ package com.kobylynskyi.graphql.test1;
1010
)
1111
public class Event implements java.io.Serializable {
1212

13+
private static final long serialVersionUID = 1L;
14+
1315
private String id;
1416
private String categoryId;
1517
private java.util.List<EventProperty> properties;
@@ -155,4 +157,4 @@ public class Event implements java.io.Serializable {
155157
}
156158

157159
}
158-
}
160+
}

src/test/resources/expected-classes/EventProperty.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ package com.kobylynskyi.graphql.test1;
1010
)
1111
public class EventProperty implements java.io.Serializable {
1212

13+
private static final long serialVersionUID = 1L;
14+
1315
private Double floatVal;
1416
private Boolean booleanVal;
1517
private int intVal;
@@ -188,4 +190,4 @@ public class EventProperty implements java.io.Serializable {
188190
}
189191

190192
}
191-
}
193+
}

src/test/resources/expected-classes/EventPropertyTO_toString.java.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import java.util.StringJoiner;
1111
)
1212
public class EventPropertyTO implements java.io.Serializable {
1313

14+
private static final long serialVersionUID = 1L;
15+
1416
private Double floatVal;
1517
private Boolean booleanVal;
1618
private int intVal;
@@ -213,4 +215,4 @@ public class EventPropertyTO implements java.io.Serializable {
213215
}
214216

215217
}
216-
}
218+
}

0 commit comments

Comments
 (0)