Add end-to-end test for Broker in different namespace to RMQ

Signed-off-by: Gerhard Lazu <[email protected]>

Author: gvmw

test/e2e/config/broker/broker.go

@@ -0,0 +1,53 @@
+/*
+Copyright 2021 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package broker
+
+import (
+	"context"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	kubeclient "knative.dev/pkg/client/injection/kube/client"
+	"knative.dev/reconciler-test/pkg/environment"
+	"knative.dev/reconciler-test/pkg/feature"
+	"knative.dev/reconciler-test/pkg/manifest"
+)
+
+func init() {
+	environment.RegisterPackage(manifest.ImagesLocalYaml()...)
+}
+
+func Install(brokerNamespace string) feature.StepFn {
+	return func(ctx context.Context, t feature.T) {
+		if _, err := manifest.InstallLocalYaml(ctx, map[string]interface{}{"broker_namespace": brokerNamespace}); err != nil {
+			t.Fatal(err)
+		}
+	}
+}
+
+func Uninstall(brokerNamespace string) feature.StepFn {
+	return func(ctx context.Context, t feature.T) {
+		if _, err := manifest.InstallLocalYaml(ctx, map[string]interface{}{"broker_namespace": brokerNamespace}); err != nil {
+			t.Fatal(err)
+		}
+
+		kubeClient := kubeclient.Get(ctx)
+
+		if err := kubeClient.CoreV1().Namespaces().Delete(context.Background(), brokerNamespace, metav1.DeleteOptions{}); err != nil {
+			t.Fatal(err)
+		}
+	}
+}

test/e2e/config/broker/broker.yaml

@@ -0,0 +1,31 @@
+# Copyright 2021 The Knative Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: {{ .broker_namespace }}
+---
+apiVersion: eventing.knative.dev/v1
+kind: Broker
+metadata:
+  name: broker
+  namespace: {{ .broker_namespace }}
+  annotations:
+    eventing.knative.dev/broker.class: RabbitMQBroker
+spec:
+  config:
+    apiVersion: rabbitmq.com/v1beta1
+    kind: RabbitmqCluster
+    name: rabbitmqc
+    namespace: {{ .namespace }}

test/e2e/config/rabbitmq/cluster.yaml

@@ -17,6 +17,10 @@ kind: RabbitmqCluster
 metadata:
   name: rabbitmqc
   namespace: {{ .namespace }}
+  annotations:
+    # We allow any Knative Broker of class RabbitMQBroker in any namespace
+    # to declare objects against this RabbitMQ cluster
+    rabbitmq.com/topology-allowed-namespaces: "*"
 spec:
   replicas: 1
   resources:

test/e2e/main_test.go

@@ -163,3 +163,12 @@ func TestSourceVhostSetup(t *testing.T) {
 	env.Test(ctx, t, VHostSourceTest())
 	env.Finish()
 }
+
+func TestBrokerInDifferentNamespaceThanRabbitMQCluster(t *testing.T) {
+	t.Parallel()
+
+	ctx, env := global.Environment()
+	env.Test(ctx, t, RabbitMQCluster())
+	env.Test(ctx, t, NamespacedBrokerTest("broker-namespace"))
+	env.Finish()
+}

test/e2e/namespaced_broker_test.go

@@ -0,0 +1,38 @@
+/*
+Copyright 2021 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package e2e
+
+import (
+	"knative.dev/eventing-rabbitmq/test/e2e/config/broker"
+
+	"knative.dev/reconciler-test/pkg/feature"
+
+	// Uncomment the following line to load the gcp plugin (only required to authenticate against GKE clusters).
+	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
+	_ "knative.dev/pkg/system/testing"
+)
+
+// MultipleBrokersUsingSingleRabbitMQClusterTest checks that Brokers in different namespaces can use the same RabbitMQ cluster
+func NamespacedBrokerTest(namespace string) *feature.Feature {
+	f := new(feature.Feature)
+
+	f.Setup("install Broker in different namespace", broker.Install(namespace))
+	f.Alpha("Broker and all dependencies - Exchange, Queue & Binding -").Must("be ready", AllGoReady)
+	f.Teardown("delete Broker namespace and all objects", broker.Uninstall(namespace))
+
+	return f
+}

test/e2e/rabbitmqcluster.go

@@ -49,7 +49,7 @@ const (
 
 // RabbitMQCluster creates a rabbitmq.com/rabbitmqclusters cluster that the
 // Broker under test will use. This assumes that the RabbitMQ Operator has
-// already been instealled.
+// already been installed.
 func RabbitMQCluster() *feature.Feature {
 	f := new(feature.Feature)