Skip to content

Commit c06cf3b

Browse files
Sven Schnellegregkh
authored andcommitted
parisc: fix warning in flush_tlb_all
[ Upstream commit 1030d68 ] I've got the following splat after enabling preemption: [ 3.724721] BUG: using __this_cpu_add() in preemptible [00000000] code: swapper/0/1 [ 3.734630] caller is __this_cpu_preempt_check+0x38/0x50 [ 3.740635] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.15.0-rc4-64bit+ torvalds#324 [ 3.744605] Hardware name: 9000/785/C8000 [ 3.744605] Backtrace: [ 3.744605] [<00000000401d9d58>] show_stack+0x74/0xb0 [ 3.744605] [<0000000040c27bd4>] dump_stack_lvl+0x10c/0x188 [ 3.744605] [<0000000040c27c84>] dump_stack+0x34/0x48 [ 3.744605] [<0000000040c33438>] check_preemption_disabled+0x178/0x1b0 [ 3.744605] [<0000000040c334f8>] __this_cpu_preempt_check+0x38/0x50 [ 3.744605] [<00000000401d632c>] flush_tlb_all+0x58/0x2e0 [ 3.744605] [<00000000401075c0>] 0x401075c0 [ 3.744605] [<000000004010b8fc>] 0x4010b8fc [ 3.744605] [<00000000401080fc>] 0x401080fc [ 3.744605] [<00000000401d5224>] do_one_initcall+0x128/0x378 [ 3.744605] [<0000000040102de8>] 0x40102de8 [ 3.744605] [<0000000040c33864>] kernel_init+0x60/0x3a8 [ 3.744605] [<00000000401d1020>] ret_from_kernel_thread+0x20/0x28 [ 3.744605] Fix this by moving the __inc_irq_stat() into the locked section. Signed-off-by: Sven Schnelle <[email protected]> Signed-off-by: Helge Deller <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 7324419 commit c06cf3b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/parisc/mm/init.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -892,9 +892,9 @@ void flush_tlb_all(void)
892892
{
893893
int do_recycle;
894894

895-
__inc_irq_stat(irq_tlb_count);
896895
do_recycle = 0;
897896
spin_lock(&sid_lock);
897+
__inc_irq_stat(irq_tlb_count);
898898
if (dirty_space_ids > RECYCLE_THRESHOLD) {
899899
BUG_ON(recycle_inuse); /* FIXME: Use a semaphore/wait queue here */
900900
get_dirty_sids(&recycle_ndirty,recycle_dirty_array);
@@ -913,8 +913,8 @@ void flush_tlb_all(void)
913913
#else
914914
void flush_tlb_all(void)
915915
{
916-
__inc_irq_stat(irq_tlb_count);
917916
spin_lock(&sid_lock);
917+
__inc_irq_stat(irq_tlb_count);
918918
flush_tlb_all_local(NULL);
919919
recycle_sids();
920920
spin_unlock(&sid_lock);

0 commit comments

Comments
 (0)