Skip to content

Commit b90f90c

Browse files
image-dragonKernel Patches Daemon
authored andcommitted
selftests/bpf: simplify the kernel_count bench trigger
Remove the "trigger_count" in trigger_bench.c and reuse trigger_driver() instead for trigger_kernel_count_setup(). With the calling to bpf_get_numa_node_id(), the result for "kernel_count" will become a little more accurate. It will also easier if we want to test the performance of livepatch, just hook the bpf_get_numa_node_id() and run the "kernel_count" bench trigger. Signed-off-by: Menglong Dong <[email protected]>
1 parent 910d3ce commit b90f90c

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

tools/testing/selftests/bpf/benchs/bench_trigger.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,8 @@ static void trigger_syscall_count_setup(void)
179179
static void trigger_kernel_count_setup(void)
180180
{
181181
setup_ctx();
182-
bpf_program__set_autoload(ctx.skel->progs.trigger_driver, false);
183-
bpf_program__set_autoload(ctx.skel->progs.trigger_count, true);
182+
ctx.skel->rodata->kernel_count = 1;
184183
load_ctx();
185-
/* override driver program */
186-
ctx.driver_prog_fd = bpf_program__fd(ctx.skel->progs.trigger_count);
187184
}
188185

189186
static void trigger_kprobe_setup(void)

tools/testing/selftests/bpf/progs/trigger_bench.c

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,19 @@ int bench_trigger_uprobe_multi(void *ctx)
3939
return 0;
4040
}
4141

42+
const volatile int kernel_count = 0;
4243
const volatile int batch_iters = 0;
4344

44-
SEC("?raw_tp")
45-
int trigger_count(void *ctx)
46-
{
47-
int i;
48-
49-
for (i = 0; i < batch_iters; i++)
50-
inc_counter();
51-
52-
return 0;
53-
}
54-
5545
SEC("?raw_tp")
5646
int trigger_driver(void *ctx)
5747
{
5848
int i;
5949

60-
for (i = 0; i < batch_iters; i++)
50+
for (i = 0; i < batch_iters; i++) {
6151
(void)bpf_get_numa_node_id(); /* attach point for benchmarking */
52+
if (kernel_count)
53+
inc_counter();
54+
}
6255

6356
return 0;
6457
}

0 commit comments

Comments
 (0)