btrfs-progs: mkfs/rootdir: factor out inode flags validation code into a helper

Currently we do the validation of inode flag parameters inside
mkfs/main.c, but considering all things like structure
rootdir_inode_flags_entry are all inside rootdir.[ch], it's better to
move the validation part into rootdir.[ch].

Extract the validation part into a helper,
btrfs_mkfs_validate_inode_flags(), into rootdir.[ch].

Signed-off-by: Qu Wenruo <[email protected]>

Author: adam900710

mkfs/main.c

@@ -1531,40 +1531,9 @@ int BOX_MAIN(mkfs)(int argc, char **argv)
 	if (ret < 0)
 		goto error;
 
-	list_for_each_entry(rif, &inode_flags_list, list) {
-		char path[PATH_MAX];
-		struct rootdir_inode_flags_entry *rif2;
-
-		if (path_cat_out(path, source_dir, rif->inode_path)) {
-			ret = -EINVAL;
-			error("path invalid: %s", path);
-			goto error;
-		}
-		if (!realpath(path, rif->full_path)) {
-			ret = -errno;
-			error("could not get canonical path: %s: %m", path);
-			goto error;
-		}
-		if (!path_exists(rif->full_path)) {
-			ret = -ENOENT;
-			error("inode path does not exist: %s", rif->full_path);
-			goto error;
-		}
-		list_for_each_entry(rif2, &inode_flags_list, list) {
-			/*
-			 * Only compare entries before us. So we won't compare
-			 * the same pair twice.
-			 */
-			if (rif2 == rif)
-				break;
-			if (strcmp(rif2->full_path, rif->full_path) == 0) {
-				error("duplicated inode flag entries for %s",
-					rif->full_path);
-				ret = -EEXIST;
-				goto error;
-			}
-		}
-	}
+	ret = btrfs_mkfs_validate_inode_flags(source_dir, &inode_flags_list);
+	if (ret < 0)
+		goto error;
 
 	if (*fs_uuid) {
 		uuid_t dummy_uuid;

mkfs/rootdir.c

@@ -1123,6 +1123,45 @@ int btrfs_mkfs_validate_subvols(const char *source_dir, struct list_head *subvol
 	return 0;
 }
 
+int btrfs_mkfs_validate_inode_flags(const char *source_dir, struct list_head *inode_flags)
+{
+	struct rootdir_inode_flags_entry *rif;
+
+	list_for_each_entry(rif, inode_flags, list) {
+		char path[PATH_MAX];
+		struct rootdir_inode_flags_entry *rif2;
+		int ret;
+
+		if (path_cat_out(path, source_dir, rif->inode_path)) {
+			error("path invalid: %s", path);
+			return -EINTR;
+		}
+		if (!realpath(path, rif->full_path)) {
+			ret = -errno;
+			error("could not get canonical path: %s: %m", path);
+			return ret;
+		}
+		if (!path_exists(rif->full_path)) {
+			error("inode path does not exist: %s", rif->full_path);
+			return -ENOENT;
+		}
+		list_for_each_entry(rif2, inode_flags, list) {
+			/*
+			 * Only compare entries before us. So we won't compare
+			 * the same pair twice.
+			 */
+			if (rif2 == rif)
+				break;
+			if (strcmp(rif2->full_path, rif->full_path) == 0) {
+				error("duplicated inode flag entries for %s",
+					rif->full_path);
+				return -EEXIST;
+			}
+		}
+	}
+	return 0;
+}
+
 static int add_file_items(struct btrfs_trans_handle *trans,
 			  struct btrfs_root *root,
 			  struct btrfs_inode_item *btrfs_inode, u64 objectid,

mkfs/rootdir.h

@@ -61,6 +61,7 @@ struct rootdir_inode_flags_entry {
 };
 
 int btrfs_mkfs_validate_subvols(const char *source_dir, struct list_head *subvols);
+int btrfs_mkfs_validate_inode_flags(const char *source_dir, struct list_head *inode_flags);
 int btrfs_mkfs_fill_dir(struct btrfs_trans_handle *trans, const char *source_dir,
 			struct btrfs_root *root, struct list_head *subvols,
 			struct list_head *inode_flags_list,