fix(tests): Restrict extra args being passed to BaseTest; fix valid BAL tests (ethereum#2102)

* - fix(fw): Restrict extra fields for ``BaseTest`` types
- refactor(tests): Remove benign extra args to blockchain tests

  After restricting extra args, some tests were failing because
  they passed extra args that do not exist on the `BlockchainTest` class.
  This does not affect the test itself but now will cause failure.
  Thankfully, mypy caught all of these so it was easier to identify.

* fix(tests,bal): Fix unreleased BAL tests from old design

- BAL tests were wrongly passing the expected BAL to the ``blockchain_test``
  itself. This was updated to live on the ``Block`` itself, but the tests
  were not updated. With the recent changes to restrict extra fields on
  the ``BlockchainTest`` (``BaseTest`` classess), this now correctly
  raises an error and allows us to have a sanity check.

Author: fselmo

amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py

@@ -43,7 +43,16 @@ def test_bal_nonce_changes(
         value=100,
     )
 
-    block = Block(txs=[tx])
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                alice: BalAccountExpectation(
+                    nonce_changes=[BalNonceChange(tx_index=1, post_nonce=1)],
+                ),
+            }
+        ),
+    )
 
     blockchain_test(
         pre=pre,
@@ -52,13 +61,6 @@ def test_bal_nonce_changes(
             alice: Account(nonce=1),
             bob: Account(balance=100),
         },
-        expected_block_access_list=BlockAccessListExpectation(
-            account_expectations={
-                alice: BalAccountExpectation(
-                    nonce_changes=[BalNonceChange(tx_index=1, post_nonce=1)],
-                ),
-            }
-        ),
     )
 
 
@@ -88,21 +90,15 @@ def test_bal_balance_changes(
         gas_price=1_000_000_000,
     )
 
-    block = Block(txs=[tx])
     alice_account = pre[alice]
     assert alice_account is not None, "Alice account should exist"
     alice_initial_balance = alice_account.balance
 
     # Account for both the value sent and gas cost (gas_price * gas_used)
     alice_final_balance = alice_initial_balance - 100 - (intrinsic_gas_cost * 1_000_000_000)
 
-    blockchain_test(
-        pre=pre,
-        blocks=[block],
-        post={
-            alice: Account(nonce=1, balance=alice_final_balance),
-            bob: Account(balance=100),
-        },
+    block = Block(
+        txs=[tx],
         expected_block_access_list=BlockAccessListExpectation(
             account_expectations={
                 alice: BalAccountExpectation(
@@ -118,6 +114,15 @@ def test_bal_balance_changes(
         ),
     )
 
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1, balance=alice_final_balance),
+            bob: Account(balance=100),
+        },
+    )
+
 
 @pytest.mark.valid_from("Amsterdam")
 def test_bal_storage_writes(
@@ -139,15 +144,8 @@ def test_bal_storage_writes(
         gas_limit=100000,
     )
 
-    block = Block(txs=[tx])
-
-    blockchain_test(
-        pre=pre,
-        blocks=[block],
-        post={
-            alice: Account(nonce=1),
-            storage_contract: Account(storage={0x01: 0x42}),
-        },
+    block = Block(
+        txs=[tx],
         expected_block_access_list=BlockAccessListExpectation(
             account_expectations={
                 storage_contract: BalAccountExpectation(
@@ -162,6 +160,15 @@ def test_bal_storage_writes(
         ),
     )
 
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1),
+            storage_contract: Account(storage={0x01: 0x42}),
+        },
+    )
+
 
 @pytest.mark.valid_from("Amsterdam")
 def test_bal_storage_reads(
@@ -181,7 +188,16 @@ def test_bal_storage_reads(
         gas_limit=100000,
     )
 
-    block = Block(txs=[tx])
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                storage_contract: BalAccountExpectation(
+                    storage_reads=[0x01],
+                ),
+            }
+        ),
+    )
 
     blockchain_test(
         pre=pre,
@@ -190,13 +206,6 @@ def test_bal_storage_reads(
             alice: Account(nonce=1),
             storage_contract: Account(storage={0x01: 0x42}),
         },
-        expected_block_access_list=BlockAccessListExpectation(
-            account_expectations={
-                storage_contract: BalAccountExpectation(
-                    storage_reads=[0x01],
-                ),
-            }
-        ),
     )
 
 
@@ -244,21 +253,10 @@ def test_bal_code_changes(
         gas_limit=500000,
     )
 
-    block = Block(txs=[tx])
-
     created_contract = compute_create_address(address=factory_contract, nonce=1)
 
-    blockchain_test(
-        pre=pre,
-        blocks=[block],
-        post={
-            alice: Account(nonce=1),
-            factory_contract: Account(nonce=2),  # incremented by CREATE to 2
-            created_contract: Account(
-                code=runtime_code_bytes,
-                storage={},
-            ),
-        },
+    block = Block(
+        txs=[tx],
         expected_block_access_list=BlockAccessListExpectation(
             account_expectations={
                 alice: BalAccountExpectation(
@@ -273,3 +271,16 @@ def test_bal_code_changes(
             }
         ),
     )
+
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1),
+            factory_contract: Account(nonce=2),  # incremented by CREATE to 2
+            created_contract: Account(
+                code=runtime_code_bytes,
+                storage={},
+            ),
+        },
+    )

osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py

@@ -198,7 +198,7 @@ def test_tx_gas_larger_than_block_gas_limit(
         exception=TransactionException.GAS_ALLOWANCE_EXCEEDED if exceed_block_gas_limit else None,
     )
 
-    blockchain_test(env=env, pre=pre, post={}, blocks=[block])
+    blockchain_test(pre=pre, post={}, blocks=[block])
 
 
 @pytest.fixture

prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py

@@ -430,7 +430,6 @@ def test_invalid_history_contract_calls(
         pre=pre,
         blocks=blocks,
         post=post,
-        reverts=reverts,
     )
 
 
@@ -490,5 +489,4 @@ def test_invalid_history_contract_calls_input_size(
         pre=pre,
         blocks=blocks,
         post=post,
-        reverts=reverts,
     )

unscheduled/eip7692_eof_v1/eip6206_jumpf/test_jumpf_execution.py

@@ -628,7 +628,6 @@ def test_jumpf_with_inputs_stack_overflow(
 def test_jumpf_infinite_loop(eof_state_test: EOFStateTestFiller, container: Container):
     """Tests JUMPF causing an infinite loop."""
     eof_state_test(
-        tx_gas=100_000,
         container=container,
         container_post=Account(storage={slot_code_worked: 0}),
     )