Fix typo

Art4 · Art4 · commit 43120390a3bc · 2024-01-09T15:55:54.000+01:00
diff --git a/src/Redmine/Api/AbstractApi.php b/src/Redmine/Api/AbstractApi.php
@@ -70,7 +70,7 @@ final protected function getHttpClient(): HttpClient
         return $this->httpClient;
     }
 
-    final protected function getLastResonse(): Response
+    final protected function getLastResponse(): Response
     {
         return $this->lastResponse !== null ? $this->lastResponse : $this->createResponse(0, '', '');
     }
@@ -234,7 +234,7 @@ protected function retrieveAll($endpoint, array $params = [])
         try {
             $data = $this->retrieveData(strval($endpoint), $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/CustomField.php b/src/Redmine/Api/CustomField.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->customFields = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Group.php b/src/Redmine/Api/Group.php
@@ -58,7 +58,7 @@ public function all(array $params = [])
         try {
             $this->groups = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Issue.php b/src/Redmine/Api/Issue.php
@@ -110,7 +110,7 @@ public function all(array $params = [])
         try {
             return $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/IssueCategory.php b/src/Redmine/Api/IssueCategory.php
@@ -69,7 +69,7 @@ public function all($project, array $params = [])
         try {
             return $this->listByProject(strval($project), $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/IssuePriority.php b/src/Redmine/Api/IssuePriority.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->issuePriorities = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/IssueRelation.php b/src/Redmine/Api/IssueRelation.php
@@ -58,7 +58,7 @@ public function all($issueId, array $params = [])
         try {
             $this->relations = $this->listByIssueId($issueId, $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/IssueStatus.php b/src/Redmine/Api/IssueStatus.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->issueStatuses = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Membership.php b/src/Redmine/Api/Membership.php
@@ -68,7 +68,7 @@ public function all($project, array $params = [])
         try {
             $this->memberships = $this->listByProject(strval($project), $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/News.php b/src/Redmine/Api/News.php
@@ -88,7 +88,7 @@ public function all($project = null, array $params = [])
                 $this->news = $this->listByProject(strval($project), $params);
             }
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Project.php b/src/Redmine/Api/Project.php
@@ -58,7 +58,7 @@ public function all(array $params = [])
         try {
             $this->projects = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Query.php b/src/Redmine/Api/Query.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->query = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Role.php b/src/Redmine/Api/Role.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->roles = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Search.php b/src/Redmine/Api/Search.php
@@ -55,7 +55,7 @@ public function search($query, array $params = [])
         try {
             $this->results = $this->listByQuery($query, $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/TimeEntry.php b/src/Redmine/Api/TimeEntry.php
@@ -57,7 +57,7 @@ public function all(array $params = [])
         try {
             $this->timeEntries = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/TimeEntryActivity.php b/src/Redmine/Api/TimeEntryActivity.php
@@ -51,7 +51,7 @@ public function all(array $params = [])
         try {
             $this->timeEntryActivities = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Tracker.php b/src/Redmine/Api/Tracker.php
@@ -55,7 +55,7 @@ public function all(array $params = [])
         try {
             $this->trackers = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/User.php b/src/Redmine/Api/User.php
@@ -58,7 +58,7 @@ public function all(array $params = [])
         try {
             $this->users = $this->list($params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Version.php b/src/Redmine/Api/Version.php
@@ -67,7 +67,7 @@ public function all($project, array $params = [])
         try {
             $this->versions = $this->listByProject(strval($project), $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/src/Redmine/Api/Wiki.php b/src/Redmine/Api/Wiki.php
@@ -67,7 +67,7 @@ public function all($project, array $params = [])
         try {
             $this->wikiPages = $this->listByProject(strval($project), $params);
         } catch (Exception $e) {
-            if ($this->getLastResonse()->getBody() === '') {
+            if ($this->getLastResponse()->getBody() === '') {
                 return false;
             }
 
diff --git a/tests/Unit/Api/AbstractApiTest.php b/tests/Unit/Api/AbstractApiTest.php
@@ -49,6 +49,27 @@ public function testCreateWithoutClitentOrHttpClientThrowsException()
         new class (new \stdClass()) extends AbstractApi {};
     }
 
+    /**
+     * @covers ::getLastResponse
+     */
+    public function testGetLastResponseWithHttpClientWorks()
+    {
+        $client = $this->createMock(HttpClient::class);
+
+        $api = new class ($client) extends AbstractApi {
+            public function __construct($client)
+            {
+                parent::__construct($client);
+                parent::get('200.json', false);
+            }
+        };
+
+        $method = new ReflectionMethod($api, 'getLastResponse');
+        $method->setAccessible(true);
+
+        $this->assertInstanceOf(Response::class, $method->invoke($api));
+    }
+
     /**
      * @test
      * @dataProvider getIsNotNullReturnsCorrectBooleanData
@@ -88,7 +109,7 @@ public static function getIsNotNullReturnsCorrectBooleanData(): array
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::lastCallFailed
+     * @covers ::lastCallFailed
      */
     public function testLastCallFailedPreventsRaceCondition()
     {
@@ -128,7 +149,7 @@ public function __construct($client)
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::lastCallFailed
+     * @covers ::lastCallFailed
      * @test
      * @dataProvider getLastCallFailedData
      */
@@ -143,7 +164,7 @@ public function testLastCallFailedWithClientReturnsCorrectBoolean($statusCode, $
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::lastCallFailed
+     * @covers ::lastCallFailed
      * @test
      * @dataProvider getLastCallFailedData
      */
@@ -238,7 +259,7 @@ public static function getLastCallFailedData(): array
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::retrieveData
+     * @covers ::retrieveData
      *
      * @dataProvider retrieveDataData
      */
@@ -265,7 +286,7 @@ public static function retrieveDataData(): array
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::retrieveData
+     * @covers ::retrieveData
      *
      * @dataProvider getRetrieveDataToExceptionData
      */
@@ -295,7 +316,7 @@ public static function getRetrieveDataToExceptionData(): array
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::retrieveAll
+     * @covers ::retrieveAll
      *
      * @dataProvider getRetrieveAllData
      */
@@ -324,7 +345,7 @@ public static function getRetrieveAllData(): array
     }
 
     /**
-     * @covers \Redmine\Api\AbstractApi::attachCustomFieldXML
+     * @covers ::attachCustomFieldXML
      */
     public function testDeprecatedAttachCustomFieldXML()
     {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ final protected function getHttpClient(): HttpClient`
`70`	`70`	`return $this->httpClient;`
`71`	`71`	`}`
`72`	`72`
`73`		`- final protected function getLastResonse(): Response`
	`73`	`+ final protected function getLastResponse(): Response`
`74`	`74`	`{`
`75`	`75`	`return $this->lastResponse !== null ? $this->lastResponse : $this->createResponse(0, '', '');`
`76`	`76`	`}`
`@@ -234,7 +234,7 @@ protected function retrieveAll($endpoint, array $params = [])`
`234`	`234`	`try {`
`235`	`235`	`$data = $this->retrieveData(strval($endpoint), $params);`
`236`	`236`	`} catch (Exception $e) {`
`237`		`- if ($this->getLastResonse()->getBody() === '') {`
	`237`	`+ if ($this->getLastResponse()->getBody() === '') {`
`238`	`238`	`return false;`
`239`	`239`	`}`
`240`	`240`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function all(array $params = [])`
`55`	`55`	`try {`
`56`	`56`	`$this->customFields = $this->list($params);`
`57`	`57`	`} catch (Exception $e) {`
`58`		`- if ($this->getLastResonse()->getBody() === '') {`
	`58`	`+ if ($this->getLastResponse()->getBody() === '') {`
`59`	`59`	`return false;`
`60`	`60`	`}`
`61`	`61`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public function all(array $params = [])`
`58`	`58`	`try {`
`59`	`59`	`$this->groups = $this->list($params);`
`60`	`60`	`} catch (Exception $e) {`
`61`		`- if ($this->getLastResonse()->getBody() === '') {`
	`61`	`+ if ($this->getLastResponse()->getBody() === '') {`
`62`	`62`	`return false;`
`63`	`63`	`}`
`64`	`64`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public function all(array $params = [])`
`110`	`110`	`try {`
`111`	`111`	`return $this->list($params);`
`112`	`112`	`} catch (Exception $e) {`
`113`		`- if ($this->getLastResonse()->getBody() === '') {`
	`113`	`+ if ($this->getLastResponse()->getBody() === '') {`
`114`	`114`	`return false;`
`115`	`115`	`}`
`116`	`116`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function all($project, array $params = [])`
`69`	`69`	`try {`
`70`	`70`	`return $this->listByProject(strval($project), $params);`
`71`	`71`	`} catch (Exception $e) {`
`72`		`- if ($this->getLastResonse()->getBody() === '') {`
	`72`	`+ if ($this->getLastResponse()->getBody() === '') {`
`73`	`73`	`return false;`
`74`	`74`	`}`
`75`	`75`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public function all($issueId, array $params = [])`
`58`	`58`	`try {`
`59`	`59`	`$this->relations = $this->listByIssueId($issueId, $params);`
`60`	`60`	`} catch (Exception $e) {`
`61`		`- if ($this->getLastResonse()->getBody() === '') {`
	`61`	`+ if ($this->getLastResponse()->getBody() === '') {`
`62`	`62`	`return false;`
`63`	`63`	`}`
`64`	`64`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function all($project, array $params = [])`
`68`	`68`	`try {`
`69`	`69`	`$this->memberships = $this->listByProject(strval($project), $params);`
`70`	`70`	`} catch (Exception $e) {`
`71`		`- if ($this->getLastResonse()->getBody() === '') {`
	`71`	`+ if ($this->getLastResponse()->getBody() === '') {`
`72`	`72`	`return false;`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public function all($project = null, array $params = [])`
`88`	`88`	`$this->news = $this->listByProject(strval($project), $params);`
`89`	`89`	`}`
`90`	`90`	`} catch (Exception $e) {`
`91`		`- if ($this->getLastResonse()->getBody() === '') {`
	`91`	`+ if ($this->getLastResponse()->getBody() === '') {`
`92`	`92`	`return false;`
`93`	`93`	`}`
`94`	`94`