Set minimum Julia version to 1.10 #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current motivation to drop support for older versions is to simplify the implementation of `round` and related methods in upcoming work.
Collaborator
Author
|
The failure in nightly is due to a recent change to a recent change to |
This was referenced May 17, 2025
kalmarek
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was busy with other things, but finally got time to get back to this!
The motivation for dropping support for versions older than Julia 1.10 is #207. The implementation I made doesn't work on Julia 1.6 due to some rounding related functions not existing. For this specific PR the issues could be worked around, but there are some potential future features where this would not be possible. The main thing I have in mind is #171, switching
setprecisionto useScopedValue. The Base implementation ofScopedValuewas introduced in Julia 1.11 but there is a compatible implementation in ScopedValues.jl, that package does however require Julia 1.8. So to implement that feature we would be required to drop support for Julia 1.6.