Fix dependency-groups in uv_translator #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
force-pushed
the
bchinn-deps
branch
from
5e6e3cc to
28500dc
Compare
brandonchinn178
changed the title
brandonchinn178
force-pushed
the
bchinn-deps
branch
3 times, most recently
from
2b6ce3c to
c0b6e8e
Compare
brandonchinn178
force-pushed
the
bchinn-deps
branch
from
c0b6e8e to
d482495
Compare
brandonchinn178
commented
Nov 5, 2025
Contributor
Author
There was a problem hiding this comment.
uv 0.4.27 was the only version that generated a lock file with package.dependency-groups: astral-sh/uv#8599
I think it's fine to drop support for that one version; people with a 0.4.27 lock file can just regenerate
brandonchinn178
force-pushed
the
bchinn-deps
branch
from
6af6266 to
2ef5b93
Compare
Contributor
Author
|
@jvolkman This should be good to go. The lock file changes are only because they were generated with specifically uv 0.4.27. Any other uv version will generate the new lock files, so I don't think it's worthwhile adding backwards compat logic |
jvolkman
approved these changes
Nov 6, 2025
| common --announce_rc | ||
| common --color=yes | ||
| common --enable_bzlmod=${{ matrix.bzlmodEnabled }} | ||
| test --test_output=errors |
Contributor
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
This broke in #186. For some reason, uv generates a
dev-dependenciessection inuv.lockfordependency-groupsinpyproject.toml; I guess uv hasn't updated their lock file with the new name. Also updated the testValidated that the test fails without the
uv_translator.pychange