Skip to content

Commit 1acc30b

Browse files
Add untracked_message_types to Page Config (#471)
* add-untracked-message-types-to-page-config * fix-tests * fix-lint * support-lower-version-test * check-CI-with-python>=3.9 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * upgrade-ci-to-python-3.9 * fix-lint * fix-code-issue --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent b969f26 commit 1acc30b

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

jupyterlab_server/app.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,14 @@ def initialize_settings(self) -> None:
123123
immutable_cache.update(extensions_url)
124124

125125
self.settings.update({"static_immutable_cache": list(immutable_cache)})
126+
if self.serverapp:
127+
untracked_message_types = getattr(
128+
self.serverapp.kernel_manager, "untracked_message_types", None
129+
)
130+
if untracked_message_types:
131+
web_app = self.serverapp.web_app
132+
page_config_data = web_app.settings.setdefault("page_config_data", {})
133+
page_config_data["untracked_message_types"] = list(untracked_message_types)
126134

127135
def initialize_templates(self) -> None:
128136
"""Initialize templates."""

jupyterlab_server/themes_handler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66

77
import os
88
import re
9+
from collections.abc import Generator
910
from glob import glob
10-
from typing import Any, Generator
11+
from typing import Any
1112
from urllib.parse import urlparse
1213

1314
from jupyter_server.base.handlers import FileFindHandler

jupyterlab_server/translation_utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
import sys
1818
import traceback
1919
from functools import lru_cache
20-
from typing import Any, Pattern
20+
from re import Pattern
21+
from typing import Any
2122

2223
import babel
2324
from packaging.version import parse as parse_version

tests/test_labapp.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ def ispath(p):
5959
return p.endswith(("Dir", "Path")) or p == "serverRoot"
6060

6161
nondirs = {k: v for k, v in page_config.items() if not ispath(k)}
62-
assert nondirs == {
62+
untracked_message_types = getattr(
63+
labserverapp.serverapp.kernel_manager, "untracked_message_types", None
64+
)
65+
expected_nondirs = {
6366
"appName": "JupyterLab Server Application",
6467
"appNamespace": "jupyterlab_server",
6568
"appUrl": "/lab",
@@ -96,6 +99,9 @@ def ispath(p):
9699
"workspacesApiUrl": "/lab/api/workspaces",
97100
"wsUrl": "",
98101
}
102+
if untracked_message_types is not None:
103+
expected_nondirs["untracked_message_types"] = untracked_message_types
104+
assert nondirs == expected_nondirs
99105

100106

101107
@pytest.fixture

0 commit comments

Comments
 (0)