Use the 'inputChange' signal in the jupyterlab-chat model

Author: brichet

packages/jupyter-chat/src/index.ts

@@ -6,6 +6,7 @@
 export * from './active-cell-manager';
 export * from './components';
 export * from './icons';
+export * from './input-model';
 export * from './model';
 export * from './registry';
 export * from './selection-watcher';

packages/jupyter-chat/src/model.ts

@@ -161,11 +161,6 @@ export interface IChatModel extends IDisposable {
    * Update the current writers list.
    */
   updateWriters(writers: IUser[]): void;
-
-  /**
-   * Function called by the input on key pressed.
-   */
-  inputChanged?(input?: string): void;
 }
 
 /**
@@ -514,11 +509,6 @@ export class ChatModel implements IChatModel {
     this._writersChanged.emit(writers);
   }
 
-  /**
-   * Function called by the input on key pressed.
-   */
-  inputChanged?(input?: string): void {}
-
   /**
    * Add unread messages to the list.
    * @param indexes - list of new indexes.

packages/jupyterlab-chat/src/model.ts

@@ -7,6 +7,7 @@ import {
   ChatModel,
   IAttachment,
   IChatMessage,
+  IInputModel,
   INewMessage,
   IUser
 } from '@jupyter/chat';
@@ -59,6 +60,8 @@ export class LabChatModel extends ChatModel implements DocumentRegistry.IModel {
     });
 
     this.sharedModel.awareness.on('change', this.onAwarenessChange);
+
+    this.input.valueChanged.connect(this.onInputChanged);
   }
 
   readonly collaborative = true;
@@ -209,8 +212,8 @@ export class LabChatModel extends ChatModel implements DocumentRegistry.IModel {
   /**
    * Function called by the input on key pressed.
    */
-  inputChanged(input?: string): void {
-    if (!input || !this.config.sendTypingNotification) {
+  onInputChanged = (_: IInputModel, value: string): void => {
+    if (!value || !this.config.sendTypingNotification) {
       return;
     }
     const awareness = this.sharedModel.awareness;
@@ -221,7 +224,7 @@ export class LabChatModel extends ChatModel implements DocumentRegistry.IModel {
     this._timeoutWriting = window.setTimeout(() => {
       this._resetWritingStatus();
     }, WRITING_DELAY);
-  }
+  };
 
   /**
    * Triggered when an awareness state changes.