Skip to content

Commit 283f0aa

Browse files
authored
Rename 'server' kind to 'frontend-and-server' (#109)
* Rename 'server' kind to 'frontend-and-server' * Remove final newline
1 parent 301be84 commit 283f0aa

File tree

16 files changed

+28
-28
lines changed

16 files changed

+28
-28
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ jobs:
230230
YARN_ENABLE_IMMUTABLE_INSTALLS: false
231231
run: |
232232
mkdir myextension
233-
python -m copier copy -l -d kind=server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
233+
python -m copier copy -l -d kind=frontend-and-server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
234234
cd myextension
235235
cat pyproject.toml
236236
pip install .
@@ -258,7 +258,7 @@ jobs:
258258
YARN_ENABLE_IMMUTABLE_INSTALLS: false
259259
run: |
260260
mkdir myextension
261-
python -m copier copy -l -d kind=server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
261+
python -m copier copy -l -d kind=frontend-and-server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
262262
cd myextension
263263
python -m pip install -e .[test]
264264
python -m pip install "jupyterlab>=4.0.0,<5" setuptools
@@ -298,7 +298,7 @@ jobs:
298298
YARN_ENABLE_IMMUTABLE_INSTALLS: false
299299
run: |
300300
mkdir myextension
301-
python -m copier copy -l -d kind=server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
301+
python -m copier copy -l -d kind=frontend-and-server -d author_name="My Name" -d repository="https://github.com/test/lab-extension" --vcs-ref HEAD --UNSAFE . myextension
302302
cd myextension
303303
python -m pip install "jupyterlab>=4.0.0,<5"
304304
jupyter lab clean --all
@@ -464,7 +464,7 @@ jobs:
464464
runs-on: ubuntu-latest
465465
strategy:
466466
matrix:
467-
kind: ["frontend", "server", "theme"]
467+
kind: ["frontend", "frontend-and-server", "theme"]
468468

469469
steps:
470470
- name: Checkout

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ A [copier](https://copier.readthedocs.io) template for creating
66
a JupyterLab extension. Four kinds of extension are supported:
77
- _frontend_: Pure frontend extension written in TypeScript.
88
- _mimerenderer_: MIME renderer extension.
9-
- _server_: Extension with frontend (in TypeScript) and backend (in Python) parts.
9+
- _frontend-and-server_: Extension with frontend (in TypeScript) and backend (in Python) parts.
1010
- _theme_: Theme for JupyterLab (using CSS variables).
1111

1212
## Use the template to create extension
@@ -38,7 +38,7 @@ cd myextension
3838
copier copy --trust https://github.com/jupyterlab/extension-template .
3939
```
4040

41-
> If you are using Visual Studio Code, you may be interested in the
41+
> If you are using Visual Studio Code, you may be interested in the
4242
> [configuration template](https://github.com/jupyterlab/vscode-config-template) for JupyterLab extension.
4343
4444
---
@@ -49,7 +49,7 @@ If you'd like to generate an extension for a older release, use the `--vcs-ref`
4949
copier copy --vcs-ref v4.0.0 --trust https://github.com/jupyterlab/extension-template .
5050
```
5151

52-
> If you are looking for a template compatible with JupyterLab version prior to 4.0.0, look at
52+
> If you are looking for a template compatible with JupyterLab version prior to 4.0.0, look at
5353
> the [cookiecutter template](https://github.com/jupyterlab/extension-cookiecutter-ts) or the
5454
> [mimerenderer template](https://github.com/jupyterlab/mimerender-cookiecutter-ts).
5555

copier.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
_min_copier_version: "7.1.0"
22
_subdirectory: template
33
_jinja_extensions:
4-
- jinja2_time.TimeExtension
4+
- jinja2_time.TimeExtension
55

66
kind:
77
type: str
@@ -10,7 +10,7 @@ kind:
1010
choices:
1111
- frontend
1212
- mimerenderer
13-
- server
13+
- frontend-and-server
1414
- theme
1515

1616
author_name:

template/.github/workflows/build.yml.jinja

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
run: |
4040
set -eux
4141
python -m pip install .[test]
42-
{% if kind.lower() == 'server' %}{% if test %}
42+
{% if kind.lower() == 'frontend-and-server' %}{% if test %}
4343
pytest -vv -r ap --cov {{ python_name }}{% endif %}
4444
jupyter server extension list
4545
jupyter server extension list 2>&1 | grep -ie "{{ python_name }}.*OK"
@@ -85,7 +85,7 @@ jobs:
8585
8686
pip install "jupyterlab>=4.0.0,<5" {{ python_name }}*.whl
8787
88-
{% if kind.lower() == 'server' %}
88+
{% if kind.lower() == 'frontend-and-server' %}
8989
jupyter server extension list
9090
jupyter server extension list 2>&1 | grep -ie "{{ python_name }}.*OK"
9191
{% endif %}

template/README.md.jinja

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
{% endif %}
88
{{ project_short_description }}
9-
{% if kind.lower() == 'server' %}
9+
{% if kind.lower() == 'frontend-and-server' %}
1010
This extension is composed of a Python package named `{{ python_name }}`
1111
for the server extension and a NPM package named `{{ labextension_name }}`
1212
for the frontend extension.
@@ -30,7 +30,7 @@ To remove the extension, execute:
3030
```bash
3131
pip uninstall {{ python_name }}
3232
```
33-
{% if kind.lower() == 'server' %}
33+
{% if kind.lower() == 'frontend-and-server' %}
3434
## Troubleshoot
3535

3636
If you are seeing the frontend extension, but it is not working, check
@@ -61,9 +61,9 @@ The `jlpm` command is JupyterLab's pinned version of
6161
# Clone the repo to your local environment
6262
# Change directory to the {{ python_name }} directory
6363
# Install package in development mode
64-
pip install -e ".{% if test and kind.lower() == 'server' %}[test]{% endif %}"
64+
pip install -e ".{% if test and kind.lower() == 'frontend-and-server' %}[test]{% endif %}"
6565
# Link your development version of the extension with JupyterLab
66-
jupyter labextension develop . --overwrite{% if kind.lower() == 'server' %}
66+
jupyter labextension develop . --overwrite{% if kind.lower() == 'frontend-and-server' %}
6767
# Server extension must be manually installed in develop mode
6868
jupyter server extension enable {{ python_name }}{% endif %}
6969
# Rebuild extension Typescript source after making changes
@@ -89,7 +89,7 @@ jupyter lab build --minimize=False
8989

9090
### Development uninstall
9191

92-
```bash{% if kind.lower() == 'server' %}
92+
```bash{% if kind.lower() == 'frontend-and-server' %}
9393
# Server extension must be manually disabled in develop mode
9494
jupyter server extension disable {{ python_name }}{% endif %}
9595
pip uninstall {{ python_name }}
@@ -99,7 +99,7 @@ In development mode, you will also need to remove the symlink created by `jupyte
9999
command. To find its location, you can run `jupyter labextension list` to figure out where the `labextensions`
100100
folder is located. Then you can remove the symlink named `{{ labextension_name }}` within that folder.
101101
{% if test %}
102-
### Testing the extension{% if kind.lower() == 'server' %}
102+
### Testing the extension{% if kind.lower() == 'frontend-and-server' %}
103103

104104
#### Server tests
105105

template/package.json.jinja

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
},
5959
"dependencies": {
6060
{% if kind.lower() != 'mimerenderer' %}"@jupyterlab/application": "^4.0.0"{% if kind.lower() == 'theme' %},
61-
"@jupyterlab/apputils": "^4.0.0"{% endif %}{% if kind.lower() == 'server' %},
61+
"@jupyterlab/apputils": "^4.0.0"{% endif %}{% if kind.lower() == 'frontend-and-server' %},
6262
"@jupyterlab/coreutils": "^6.0.0",
6363
"@jupyterlab/services": "^7.0.0"{% endif %}{% if has_settings %},
6464
"@jupyterlab/settingregistry": "^4.0.0"{% endif %}{% else %}"@jupyterlab/rendermime-interfaces": "^3.8.0",
@@ -77,7 +77,7 @@
7777
"eslint": "^8.36.0",
7878
"eslint-config-prettier": "^8.8.0",
7979
"eslint-plugin-prettier": "^5.0.0",{% if test %}
80-
"jest": "^29.2.0",{% endif %}{% if kind.lower() == 'server' %}
80+
"jest": "^29.2.0",{% endif %}{% if kind.lower() == 'frontend-and-server' %}
8181
"mkdirp": "^1.0.3",{% endif %}
8282
"npm-run-all2": "^7.0.1",
8383
"prettier": "^3.0.0",
@@ -101,7 +101,7 @@
101101
"publishConfig": {
102102
"access": "public"
103103
},
104-
"jupyterlab": { {%- if kind.lower() == 'server' %}
104+
"jupyterlab": { {%- if kind.lower() == 'frontend-and-server' %}
105105
"discovery": {
106106
"server": {
107107
"managers": [

template/pyproject.toml.jinja

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ classifiers = [
2424
"Programming Language :: Python :: 3.12",
2525
"Programming Language :: Python :: 3.13",
2626
]
27-
dependencies = [{% if kind.lower() == "server" %}
27+
dependencies = [{% if kind.lower() == "frontend-and-server" %}
2828
"jupyter_server>=2.4.0,<3"{% endif %}
2929
]
3030
dynamic = ["version", "description", "authors", "urls", "keywords"]
31-
{% if test and kind.lower() == 'server' %}
31+
{% if test and kind.lower() == 'frontend-and-server' %}
3232
[project.optional-dependencies]
3333
test = [
3434
"coverage",
@@ -50,7 +50,7 @@ exclude = [".github", "binder"]
5050

5151
[tool.hatch.build.targets.wheel.shared-data]
5252
"{{ python_name }}/labextension" = "share/jupyter/labextensions/{{ labextension_name }}"
53-
"install.json" = "share/jupyter/labextensions/{{ labextension_name }}/install.json"{% if kind.lower() == "server" %}
53+
"install.json" = "share/jupyter/labextensions/{{ labextension_name }}/install.json"{% if kind.lower() == "frontend-and-server" %}
5454
"jupyter-config/server-config" = "etc/jupyter/jupyter_server_config.d"{% endif %}
5555

5656
[tool.hatch.build.hooks.version]

template/src/index.ts.jinja

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { IThemeManager } from '@jupyterlab/apputils';{% endif %}{% if has_settings %}
77

8-
import { ISettingRegistry } from '@jupyterlab/settingregistry';{% endif %}{% if kind.lower() == 'server' %}
8+
import { ISettingRegistry } from '@jupyterlab/settingregistry';{% endif %}{% if kind.lower() == 'frontend-and-server' %}
99

1010
import { requestAPI } from './handler';{% endif %}
1111

@@ -38,7 +38,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
3838
.catch(reason => {
3939
console.error('Failed to load settings for {{ labextension_name }}.', reason);
4040
});
41-
}{% endif %}{% if kind.lower() == 'server' %}
41+
}{% endif %}{% if kind.lower() == 'frontend-and-server' %}
4242

4343
requestAPI<any>('get-example')
4444
.then(data => {

template/{% if has_binder %}binder{% endif %}/postBuild.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ _(sys.executable, "-m", "pip", "check")
3131

3232
# install the labextension
3333
_(sys.executable, "-m", "pip", "install", "-e", ".")
34-
_(sys.executable, "-m", "jupyter", "labextension", "develop", "--overwrite", "."){% if kind.lower() == 'server' %}
34+
_(sys.executable, "-m", "jupyter", "labextension", "develop", "--overwrite", "."){% if kind.lower() == 'frontend-and-server' %}
3535
_(
3636
sys.executable,
3737
"-m",

0 commit comments

Comments
 (0)