Skip to content

Commit fd316d5

Browse files
authored
Merge pull request #1313 from mathbunnyru/asalikhov/makefile_codestyle
Simplify Makefile
2 parents 2aa1bc9 + ca2bdfd commit fd316d5

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

Makefile

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ OWNER?=jupyter
99

1010
# Need to list the images in build dependency order
1111
ifeq ($(ARCH),ppc64le)
12-
ALL_STACKS:=base-notebook
12+
ALL_IMAGES:=base-notebook
1313
else
14-
ALL_STACKS:=base-notebook \
14+
ALL_IMAGES:=base-notebook \
1515
minimal-notebook \
1616
r-notebook \
1717
scipy-notebook \
@@ -21,13 +21,11 @@ ALL_STACKS:=base-notebook \
2121
all-spark-notebook
2222
endif
2323

24-
ALL_IMAGES:=$(ALL_STACKS)
25-
2624
# Enable BuildKit for Docker build
2725
export DOCKER_BUILDKIT:=1
2826

29-
help:
3027
# http://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
28+
help:
3129
@echo "jupyter/docker-stacks"
3230
@echo "====================="
3331
@echo "Replace % with a stack directory name (e.g., make build/minimal-notebook)"
@@ -37,10 +35,10 @@ help:
3735
arch_patch/%: ## apply hardware architecture specific patches to the Dockerfile
3836
@if [ -e ./$(notdir $@)/Dockerfile.$(ARCH).patch ]; then \
3937
if [ -e ./$(notdir $@)/Dockerfile.orig ]; then \
40-
cp -f ./$(notdir $@)/Dockerfile.orig ./$(notdir $@)/Dockerfile;\
41-
else\
42-
cp -f ./$(notdir $@)/Dockerfile ./$(notdir $@)/Dockerfile.orig;\
43-
fi;\
38+
cp -f ./$(notdir $@)/Dockerfile.orig ./$(notdir $@)/Dockerfile; \
39+
else \
40+
cp -f ./$(notdir $@)/Dockerfile ./$(notdir $@)/Dockerfile.orig; \
41+
fi; \
4442
patch -f ./$(notdir $@)/Dockerfile ./$(notdir $@)/Dockerfile.$(ARCH).patch; \
4543
fi
4644

@@ -107,7 +105,7 @@ img-list: ## list jupyter images
107105
@echo "Listing $(OWNER) images ..."
108106
docker images "$(OWNER)/*"
109107

110-
img-rm: ## remove jupyter images
108+
img-rm: ## remove jupyter images
111109
@echo "Removing $(OWNER) images ..."
112110
-docker rmi --force $(shell docker images --quiet "$(OWNER)/*") 2> /dev/null
113111

0 commit comments

Comments
 (0)