enh: add harp config #382
enh: add harp config #382
Conversation
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
enh/harp-config
branch
from
ea70855 to
bee1ce6
Compare
docker-compose.yml
Outdated
| environment: | ||
| - NC_HARP_SHARED_KEY=${NC_HAPROXY_SHARED_KEY:-some_very_secure_password} | ||
| - NC_INSTANCE_URL=${NC_INSTANCE_URL:-http://nextcloud.local} | ||
| - HP_FRP_DISABLE_TLS=${HP_FRP_DISABLE_TLS:-true} |
There was a problem hiding this comment.
do not needed, better to check without this flag set to True. by default we will use auto generated TLS
There was a problem hiding this comment.
Maybe we can reuse the PROTOCOL env variable that is used to indicate if the setup uses TLS or not in general
There was a problem hiding this comment.
those value is related to the communication type between HaRP and ExApp only.
we will describe this in the documentation when will work on it.
by default we will always recomend to not disable it.
docker-compose.yml
Outdated
| - /var/run/docker.sock:/var/run/docker.sock | ||
| environment: | ||
| - NC_HARP_SHARED_KEY=${NC_HAPROXY_SHARED_KEY:-some_very_secure_password} | ||
| - NC_INSTANCE_URL=${NC_INSTANCE_URL:-http://nextcloud.local} |
There was a problem hiding this comment.
We should call that something like NC_HARP_INSTANCE_URL, the rest of the setup is usually not pinned to a single nextcloud instance.
There was a problem hiding this comment.
Out of interest: Is there a way to use one harp server for multiple nextcloud servers?
There was a problem hiding this comment.
Out of interest: Is there a way to use one harp server for multiple nextcloud servers?
unfortunately, at the moment - definitely not
| @@ -0,0 +1,8 @@ | |||
| location / { | |||
There was a problem hiding this comment.
Doesn't this need to go in a file jsut called nextcloud.local https://github.com/nginx-proxy/nginx-proxy/tree/main/docs#per-virtual_host or is it possible to have multiple?
There was a problem hiding this comment.
yeah that didn't seem to work
we used this: https://github.com/nginx-proxy/nginx-proxy/tree/main/docs#overriding-location-blocks but the location / was also removed from the main config
maybe _location would allow to add just additional locations, will test
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
docker-compose.yml
Outdated
| container_name: nextcloud-appapi-harp | ||
| network_mode: ${HP_NETWORK_MODE:-master_default} |
There was a problem hiding this comment.
I'm curious about those parts, why do we need to set the network mode here actually?
There was a problem hiding this comment.
One can work with different kinds of configurations like host or any other network, for testing.
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
|
container_name seems necessary for dns setting so the proxy _location addition can connect to it "DNSNames": [
"master-appapi-harp-1",
"2b4545c5162e"
] |
3 participants
No description provided.