Skip to content

Commit c2c9ad9

Browse files
author
Julien Maurel
committed
Fix issue without js.cookie
1 parent cb3925e commit c2c9ad9

File tree

6 files changed

+16
-13
lines changed

6 files changed

+16
-13
lines changed

CHANGELOG.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
1.9.1
2+
Fix issue without jquery.cookie
3+
14
1.9.0
25
Replace jquery.cookie (no longer maintained) by js-cookie
36
Add gulp task to generate minified version

Jasmine/spec/jquery.storageapi_spec.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function testStorage(name){
1818
function clearAll(){
1919
wl.clear();
2020
ws.clear();
21-
if (Cookies) {
21+
if (typeof Cookies === 'object') {
2222
for (var key in Cookies.get()) {
2323
if(key!='') {
2424
Cookies.remove(key, {path: window.cookieStorage._path});
@@ -50,7 +50,7 @@ describe("Jquery.StorageApi", function() {
5050
expect($.namespaceStorages['test_ns']).toEqual(ns);
5151
expect(wl.getItem('test_ns')).toEqual("{}");
5252
expect(ws.getItem('test_ns')).toEqual("{}");
53-
if (Cookies) {
53+
if (typeof Cookies === 'object') {
5454
expect(window.cookieStorage.getItem('test_ns')).toEqual("{}");
5555
}
5656
});
@@ -59,14 +59,14 @@ describe("Jquery.StorageApi", function() {
5959

6060
/* Tests on all storage */
6161
var storage_types=['localStorage','sessionStorage'];
62-
if (Cookies) {
62+
if (typeof Cookies === 'object') {
6363
storage_types.push('cookieStorage');
6464
}else{
6565
console.log("Skipping $.cookieStorage specs. Could not load JQuery js-cookie.");
6666
}
6767
storage_types.push('ns.localStorage');
6868
storage_types.push('ns.sessionStorage');
69-
if (Cookies) {
69+
if (typeof Cookies === 'object') {
7070
storage_types.push('ns.cookieStorage');
7171
}
7272

@@ -406,7 +406,7 @@ describe("Jquery.StorageApi", function() {
406406
expect($.sessionStorage.get("item")).toEqual(null);
407407
expect($.localStorage.get("test_ns")).toEqual(null);
408408
expect($.sessionStorage.get("test_ns")).toEqual(null);
409-
if (Cookies) {
409+
if (typeof Cookies === 'object') {
410410
expect($.cookieStorage.get("item")).toEqual(null);
411411
expect($.cookieStorage.get("test_ns")).toEqual(null);
412412
}
@@ -422,7 +422,7 @@ describe("Jquery.StorageApi", function() {
422422
expect($.sessionStorage.get("item")).toEqual(null);
423423
expect($.localStorage.get("test_ns")).toEqual({});
424424
expect($.sessionStorage.get("test_ns")).toEqual({});
425-
if (Cookies) {
425+
if (typeof Cookies === 'object') {
426426
expect($.cookieStorage.get("item")).toEqual(null);
427427
expect($.cookieStorage.get("test_ns")).toEqual({});
428428
}

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "jquery-storage-api",
33
"title": "jQuery Storage API",
4-
"version": "1.9.0",
4+
"version": "1.9.1",
55
"main": "jquery.storageapi.js",
66
"description": "jQuery Storage API is a plugin that simplify access to storages (HTML5) & cookies, add namespace storage functionality and provide compatiblity for old browsers with cookies!",
77
"keywords": [

jquery.storageapi.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* Project home:
1010
* https://github.com/julien-maurel/jQuery-Storage-API
1111
*
12-
* Version: 1.9.0
12+
* Version: 1.9.1
1313
*/
1414
(function (factory) {
1515
if (typeof define === 'function' && define.amd) {
@@ -311,7 +311,7 @@
311311
localStorage: $.extend({}, $.localStorage, {_ns: name}),
312312
sessionStorage: $.extend({}, $.sessionStorage, {_ns: name})
313313
};
314-
if (Cookies) {
314+
if (typeof Cookies === 'object') {
315315
if (!window.cookieStorage.getItem(name)) {
316316
window.cookieStorage.setItem(name, '{}');
317317
}
@@ -417,7 +417,7 @@
417417
};
418418

419419
// Use js-cookie for compatibility with old browsers and give access to cookieStorage
420-
if (Cookies) {
420+
if (typeof Cookies === 'object') {
421421
// sessionStorage is valid for one window/tab. To simulate that with cookie, we set a name for the window and use it for the name of the cookie
422422
if (!window.name) {
423423
window.name = Math.floor(Math.random() * 100000000);

jquery.storageapi.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jquery-storage-api",
3-
"version": "1.9.0",
3+
"version": "1.9.1",
44
"title": "jQuery Storage API",
55
"author": {
66
"name": "Julien Maurel",

0 commit comments

Comments
 (0)