Skip to content

[Fix] no-unknown-property add properties onToggle, fill, as, pointer events, media events and touch events #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2022
Merged

[Fix] no-unknown-property add properties onToggle, fill, as, pointer events, media events and touch events #3385

merged 5 commits into from
Sep 4, 2022

Conversation

@sjarva
Copy link
Contributor

@sjarva sjarva commented Sep 3, 2022

Closes #3384

@codecov
Copy link

codecov bot commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #3385 (652749d) into master (91ea5d5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
+ Coverage   97.57%   97.58%   +0.01%     
==========================================
  Files         123      123              
  Lines        8954     8957       +3     
  Branches     3268     3269       +1     
==========================================
+ Hits         8737     8741       +4     
+ Misses        217      216       -1
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <100.00%> (+1.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ljharb
ljharb reviewed Sep 3, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjarva
Copy link
Contributor Author

sjarva commented Sep 3, 2022

I made the suggestions you had ✔️

@sjarva sjarva requested a review from ljharb September 3, 2022 15:27
@sjarva sjarva changed the title [Fix] add properties onToggle, fill, as and pointer events [Fix] no-unknown-property add properties onToggle, fill, as and pointer events Sep 3, 2022
@jdufresne
Copy link

jdufresne commented Sep 3, 2022 •
edited
Loading

My project started emitting eslint errors when using touch events. I don't see them events listed in this change. Could/should they also be included?

https://reactjs.org/docs/events.html#touch-events

  • onTouchCancel
  • onTouchEnd
  • onTouchMove
  • onTouchStart

@sjarva sjarva changed the title [Fix] no-unknown-property add properties onToggle, fill, as and pointer events [Fix] no-unknown-property add properties onToggle, fill, as, pointer events, media events and touch events Sep 3, 2022
@sjarva
Copy link
Contributor Author

sjarva commented Sep 3, 2022

Thanks for pointing them out @jdufresne 👍
I added touch event and media related properties to this PR.

@chrisweb chrisweb mentioned this pull request Sep 3, 2022
Closed
@ljharb ljharb mentioned this pull request Sep 3, 2022
Merged
@ljharb
[Fix] no-unknown-property: children is always an acceptable prop;…
a2ec87d 
… iframes have `scrolling`; video has `playsInline`
@ljharb ljharb force-pushed the no-unknown-property-more-valid-properties branch from d452ea7 to a2ec87d Compare September 4, 2022 04:40
@ljharb ljharb merged commit 652749d into jsx-eslint:master Sep 4, 2022
@sjarva sjarva deleted the no-unknown-property-more-valid-properties branch September 4, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[7.31.4] no-unknown-property throwing on valid props

3 participants

@sjarva @jdufresne @ljharb