fix: correct test suite test case

Author: DannyvdSluijs

tests/Constraints/BaseTestCase.php

@@ -43,7 +43,7 @@ public function testInvalidCases($input, $schema, $checkMode = Constraint::CHECK
         $checkValue = json_decode($input);
         $errorMask = $validator->validate($checkValue, $schema);
 
-        $this->assertTrue((bool) ($errorMask & Validator::ERROR_DOCUMENT_VALIDATION));
+        $this->assertTrue((bool) ($errorMask & Validator::ERROR_DOCUMENT_VALIDATION), 'Document is invalid');
         $this->assertGreaterThan(0, $validator->numErrors());
 
         if ([] !== $errors) {

tests/JsonSchemaTestSuite.php renamed to tests/JsonSchemaTestSuiteTest.php

@@ -13,25 +13,31 @@
 use RecursiveDirectoryIterator;
 use RecursiveIteratorIterator;
 
-class JsonSchemaTestSuite extends TestCase
+class JsonSchemaTestSuiteTest extends TestCase
 {
     /**
      * @dataProvider casesDataProvider
      */
-    public function testIt(
+    public function testTestCaseValidatesCorrectly(
         string $testCaseDescription,
         string $testDescription,
         \stdClass $schema,
         mixed $data,
-        bool $expectedValidationResult
+        bool $expectedValidationResult,
+        bool $optional
     ): void
     {
         $schemaStorage = new SchemaStorage();
         $schemaStorage->addSchema(property_exists($schema, 'id') ? $schema->id : SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI, $schema);
         $this->loadRemotesIntoStorage($schemaStorage);
         $validator = new Validator(new Factory($schemaStorage));
 
-        $result = $validator->validate($data, $schema);
+        $validator->validate($data, $schema);
+
+        if ($optional && $expectedValidationResult !== (count($validator->getErrors()) === 0)) {
+            $this->markTestSkipped('Optional test case would fail');
+            return;
+        }
 
         self::assertEquals($expectedValidationResult, count($validator->getErrors()) === 0);
     }
@@ -65,7 +71,7 @@ function ($file) {
                         $name = sprintf(
                             '[%s/%s%s]: %s: %s is expected to be %s',
                             basename($draft),
-                            str_contains($file->getPathname(), 'optional') ? 'optional/' : '',
+                            str_contains($file->getPathname(), '/optional/') ? 'optional/' : '',
                             $file->getBasename(),
                             $testCase->description,
                             $test->description,
@@ -78,6 +84,7 @@ function ($file) {
                             'schema' => $testCase->schema,
                             'data' => $test->data,
                             'expectedValidationResult' => $test->valid,
+                            'optional' => str_contains($file->getPathname(), '/optional/')
                         ];
                     }