Skip to content

Compile with strictNullChecks/strictPropertyInitialization (focus on calendar.ts and ecmascript.ts) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 11, 2022
Merged

Compile with strictNullChecks/strictPropertyInitialization (focus on calendar.ts and ecmascript.ts) #109

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
44db035
Only require year in Gergorian `inLeapYear` method
justingrant Dec 16, 2021
7b1c123
Add new calendar types
justingrant Dec 16, 2021
a6b5854
Bulk renames to use new calendar types
justingrant Dec 16, 2021
3d386ca
Use new calendar types throughout
justingrant Dec 16, 2021
1ad8315
More precise TS types in ecmascript.ts
justingrant Dec 16, 2021
196295e
Tighten types of intl.ts
justingrant Dec 16, 2021
bfa0110
Support strictNullChecks in intrinsics.ts
justingrant Dec 16, 2021
2885500
strtictNullChecks in PT, TZ, and ZDT code
justingrant Dec 16, 2021
d5a6c76
tsconfig changes
justingrant Dec 16, 2021
245b568
Changes from code reviews
justingrant Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,8 +1691,11 @@ const makeHelperGregorian = (id: BuiltinCalendarId, originalEras: InputEra[]) =>
eras,
anchorEra,
calendarType: 'solar',
inLeapYear(calendarDate /*, cache */) {
const { year } = this.estimateIsoDate(calendarDate);
inLeapYear(calendarDate /*, cache: OneObjectCache */) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the overriding calendars use the month and day to determine inLeapYear? If not, maybe we could just pass year: number to this method instead of what is effectively calendarDate: { year: number }?

// Calendars that don't override this method use the same months and leap
// years as Gregorian. Once we know the ISO year corresponding to the
// calendar year, we'll know if it's a leap year or not.
const { year } = this.estimateIsoDate({ month: 1, day: 1, year: calendarDate.year });
return isGregorianLeapYear(year);
},
monthsInYear(/* calendarDate */) {
Expand Down