Skip to content

Commit 1dc82e8

Browse files
committed
Resolve ignore-errors lint warnings
This uses the apt lock workaround to replace an ignore_errors on update and also just totally removes another ignore_errors for writing to the .bashrcs of users. If that's failing, we probably need to make our filter a bit better.
1 parent 38f871f commit 1dc82e8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

roles/common/tasks/main.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,6 @@
6464
- name: Refresh apt cache
6565
apt:
6666
update_cache: yes
67-
changed_when: false
68-
ignore_errors: yes
67+
register: apt_update
68+
retries: 100
69+
until: apt_update is success or ('Failed to lock apt for exclusive operation' not in apt_update.msg and '/var/lib/dpkg/lock' not in apt_update.msg)

roles/user/tasks/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
# sources our profile. We won't create the file if it doesn't exist and
9393
# we can ignore any errors
9494
create: no
95-
ignore_errors: yes
9695
loop: "{{ real_users }}"
9796
- name: Remove Timeshift warning
9897
dconf:

0 commit comments

Comments
 (0)