Skip to content

Conversation

@red-hat-konflux-kflux-prd-rh03
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/prometheus/client_golang v1.22.0 -> v1.23.2 age confidence

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.23.2: - 2025-09-05

Compare Source

This release is made to upgrade to prometheus/common v0.66.1, which drops the dependencies github.com/grafana/regexp and go.uber.org/atomic and replaces gopkg.in/yaml.v2 with go.yaml.in/yaml/v2 (a drop-in replacement). There are no functional changes.

All Changes

Full Changelog: prometheus/client_golang@v1.23.1...v1.23.2

v1.23.1: - 2025-09-04

Compare Source

This release is made to be compatible with a backwards incompatible API change in prometheus/common v0.66.0. There are no functional changes.

All Changes

Full Changelog: prometheus/client_golang@v1.23.0...v1.23.1

v1.23.0: - 2025-07-30

Compare Source

  • [CHANGE] Minimum required Go version is now 1.23, only the two latest Go versions are supported from now on. #​1812
  • [FEATURE] Add WrapCollectorWith and WrapCollectorWithPrefix #​1766
  • [FEATURE] Add exemplars for native histograms #​1686
  • [ENHANCEMENT] exp/api: Bubble up status code from writeResponse #​1823
  • [ENHANCEMENT] collector/go: Update runtime metrics for Go v1.23 and v1.24 #​1833
  • [BUGFIX] exp/api: client prompt return on context cancellation #​1729
All Changes * Update example test by @​SuperQ in https://github.com/prometheus/client_golang/pull/1770 * build(deps): bump golang.org/x/net from 0.34.0 to 0.36.0 in /tutorials/whatsup by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1776 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1771 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1778 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1779 * build(deps): bump google.golang.org/protobuf from 1.36.5 to 1.36.6 in /exp by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1782 * build(deps): bump github.com/prometheus/common from 0.62.0 to 0.63.0 in /exp by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1781 * build(deps): bump github.com/prometheus/common from 0.62.0 to 0.63.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1783 * build(deps): bump google.golang.org/protobuf from 1.36.5 to 1.36.6 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1784 * build(deps): bump github.com/prometheus/procfs from 0.15.1 to 0.16.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1786 * chore: Upgrade golangci-lint to v2 by @​kakkoyun in https://github.com/prometheus/client_golang/pull/1789 * build(deps): bump the github-actions group across 1 directory with 3 updates by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1790 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1791 * Add `WrapCollectorWith` and `WrapCollectorWithPrefix` by @​colega in https://github.com/prometheus/client_golang/pull/1766 * feat(github-actions): add Go file change detection to golangci-lint workflow by @​kakkoyun in https://github.com/prometheus/client_golang/pull/1794 * chore(ci): Fix flaky tests by @​kakkoyun in https://github.com/prometheus/client_golang/pull/1795 * build(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /tutorials/whatsup by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1799 * test(registry): Add goleak-based goroutine leak detection by @​surinkim in https://github.com/prometheus/client_golang/pull/1797 * build(deps): bump go.uber.org/goleak from 1.2.0 to 1.3.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1806 * build(deps): bump the github-actions group with 2 updates by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1804 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1809 * Add exemplars for native histograms by @​shivanthzen in https://github.com/prometheus/client_golang/pull/1686 * build(deps): bump golang.org/x/sys from 0.30.0 to 0.32.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1807 * build(deps): bump github.com/prometheus/client_model from 0.6.1 to 0.6.2 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1805 * build(deps): bump github.com/prometheus/procfs from 0.16.0 to 0.16.1 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1808 * build(deps): bump golang.org/x/net from 0.35.0 to 0.38.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1800 * Update supported Go versions by @​SuperQ in https://github.com/prometheus/client_golang/pull/1812 * Cleaup Go modules by @​SuperQ in https://github.com/prometheus/client_golang/pull/1813 * fix: client prompt return on context cancellation by @​umegbewe in https://github.com/prometheus/client_golang/pull/1729 * Simplify buf binary install by @​SuperQ in https://github.com/prometheus/client_golang/pull/1814 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1815 * build(deps): bump the github-actions group with 5 updates by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1817 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1821 * exp/api: Bubble up status code from writeResponse by @​saswatamcode in https://github.com/prometheus/client_golang/pull/1823 * build(deps): bump github.com/prometheus/common from 0.64.0 to 0.65.0 by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1827 * build(deps): bump github.com/prometheus/common from 0.64.0 to 0.65.0 in /exp by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1828 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1831 * Update runtime metrics for Go v1.23 and v1.24 by @​aknuds1 in https://github.com/prometheus/client_golang/pull/1833 * Fix `errNotImplemented` reference by @​aknuds1 in https://github.com/prometheus/client_golang/pull/1835 * build(deps): bump the github-actions group with 3 updates by @​dependabot[bot] in https://github.com/prometheus/client_golang/pull/1826 * Synchronize common files from prometheus/prometheus by @​prombot in https://github.com/prometheus/client_golang/pull/1832 * Cut v1.23.0-rc.0 by @​vesari in https://github.com/prometheus/client_golang/pull/1837 * cut v1.23.0-rc.1 by @​vesari in https://github.com/prometheus/client_golang/pull/1842

New Contributors

Full Changelog: prometheus/client_golang@v1.22.0...v1.23.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

…23.2

Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
@claude
Copy link

claude bot commented Nov 4, 2025

Pull Request Review: Prometheus Client Update

Summary

This PR updates github.com/prometheus/client_golang from v1.22.0 to v1.23.2, along with transitive dependency updates to prometheus/common (v0.62.0 → v0.66.1) and prometheus/procfs (v0.15.1 → v0.16.1).

Code Quality: ✅ Excellent

Positive Aspects:

  • Clean, automated dependency update with no functional code changes required
  • All changes are limited to go.mod and go.sum - proper dependency-only update
  • Updates include bug fixes and dependency cleanup from upstream

Compatibility Analysis: ✅ Compatible

Go Version Requirement:

  • ⚠️ Important: prometheus/client_golang v1.23.0+ requires Go 1.23+
  • ✅ This project uses Go 1.24.0 (as specified in go.mod:3), so compatibility is confirmed
  • The Prometheus library now only supports the two latest Go versions (1.23 and 1.24)

Dependency Updates:

  1. prometheus/client_golang v1.23.2 includes:

    • Upgraded to prometheus/[email protected] (drops grafana/regexp and uber.org/atomic dependencies)
    • Replaces gopkg.in/yaml.v2 with go.yaml.in/yaml/v2 (drop-in replacement)
    • Bug fix: context cancellation now properly handled in exp/api client
    • Enhancement: Status code bubbling in exp/api
    • Enhancement: Updated runtime metrics for Go 1.23 and 1.24
    • Feature: Exemplars support for native histograms
  2. No breaking API changes affecting this codebase (prometheus/client_golang is an indirect dependency via controller-runtime)

Security: ✅ No Concerns

  • No known security vulnerabilities in the updated versions
  • Reduces dependency footprint by dropping grafana/regexp and uber.org/atomic
  • All changes are from trusted Prometheus project maintainers

Performance: ✅ Neutral to Positive

  • No performance regressions expected
  • Enhanced runtime metrics collection for Go 1.23/1.24 may provide better observability
  • Dependency cleanup reduces overall binary size marginally

Test Coverage: ✅ Adequate

Recommendations:

  1. ✅ Run make test to ensure unit tests pass
  2. ✅ Run make test-integration to verify controller-runtime metrics integration
  3. ✅ Verify the build succeeds: make build

Since prometheus/client_golang is an indirect dependency (pulled in by controller-runtime), and the project doesn't directly import or use Prometheus client libraries, the risk is minimal.

Potential Issues: ⚠️ Minor

Go Version Dependency:

  • CI/CD pipelines must use Go 1.23+ (project already uses Go 1.24.4 toolchain, so this is satisfied)
  • Developers must have Go 1.23+ locally

Testing Recommendations:

  • Verify tests pass with new dependencies: make test-unit and make test-integration
  • Verify build succeeds: make build
  • If running in a cluster, verify metrics endpoint still works: curl http://localhost:8080/metrics

Recommendation: ✅ APPROVE & MERGE

This is a safe, well-structured dependency update that:

  • Maintains compatibility with the project's Go version requirements
  • Includes bug fixes and enhancements from upstream
  • Reduces dependency complexity
  • Poses minimal risk as an indirect dependency

Merge Confidence: High - This is a routine maintenance update from a trusted automated source (Renovate) with no breaking changes for this codebase.


Review generated by Claude Code following project conventions from CLAUDE.md

@github-actions github-actions bot merged commit dd059d5 into main Nov 4, 2025
6 of 8 checks passed
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🤖 Auto-merge enabled for this MintMaker PR (detected as minor_or_patch). Will merge automatically when all required checks pass.

@red-hat-konflux-kflux-prd-rh03 red-hat-konflux-kflux-prd-rh03 bot deleted the konflux/mintmaker/main/github.com-prometheus-client_golang-1.x branch November 5, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant