Issue #13029 - clear out inflater/deflater buffers when input consumed #13034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
Apr 23, 2025
Contributor
sbordet
left a comment
sbordet
left a comment
There was a problem hiding this comment.
@lachlan-roberts the fix looks good, but the OP reported that the byte[] also had a reference from PerMessageDeflateExtension.OutgoingFlusher._frame.
I don't see that reference being cleared after the write, so I think we still have that problem.
In general, I think all the outgoing flushers should be reviewed to clear the fields they use for the writes.
…n OutgoingFlusher Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
Apr 24, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.0.20 - FROZEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13029
This prevents the inflater/deflater from holding a reference to the frames buffer when it is fully consumed and awaiting the next frame/message.
I could not find a way to write a test case for this, but tested manually by accessing the
DeflaterPool, getting theDeflaterused by the websocket session, and using reflection to view its internal buffer.