Skip to content

Commit 81661da

Browse files
committed
Assorted typos
1 parent d075c69 commit 81661da

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,10 +308,10 @@ A key facility of this repo is being able to run load tests, either in process a
308308
309309
- `Favorite` - Simulate a very enthusiastic user that favorites something once per second
310310
- the test generates an ever-growing state that can only be managed efficiently if you apply either caching, snapshotting or both
311-
- NB due to being unbounded, even Rolling Snapshots or Unfolds will eventually hit the Store's limits (4MB/event for EventStore, 3MB/Item (document) for CosmosDB)
311+
- NB due to being unbounded, `RollingSnapshots`, `Snapshot`, `Unfolded` etc. will eventually hit the Store's limits (4MB/event for EventStore, 3MB/Item (document) for CosmosDB)
312312
- `SaveForLater` - Simulate a happy shopper that saves 3 items per second, and empties the Save For Later list whenever it is full (when it hits 50 items)
313313
- Snapshotting helps a lot
314-
- Caching is not as essential as it is for the `Favorite` test (as long as oyu have either aching or snapshotting, that is)
314+
- Caching is not as essential as it is for the `Favorite` test (as long as you have either caching or snapshotting, that is)
315315
- `Todo` - Keeps a) getting the list b) adding an item c) clearing the list when it hits 1000 items.
316316
- the `Cleared` event acts as a natural event to use in the `isOrigin` check. This makes snapshotting less crucial than it is, for example, in the case of the `Favorite` test
317317
- the `-s` parameter can be used to adjust the maximum item text length from the default (`100`, implying average length of 50)

samples/Store/Integration/CartIntegration.fs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ let resolveGesStreamWithRollingSnapshots gateway =
2323
let resolveGesStreamWithoutCustomAccessStrategy gateway =
2424
EventStore.Resolver(gateway, codec, fold, initial).Resolve
2525

26-
let resolveCosmosStreamWithProjection gateway =
26+
let resolveCosmosStreamWithSnapshotStrategy gateway =
2727
Cosmos.Resolver(gateway, codec, fold, initial, Cosmos.CachingStrategy.NoCaching, Cosmos.AccessStrategy.Snapshot snapshot).Resolve
2828
let resolveCosmosStreamWithoutCustomAccessStrategy gateway =
2929
Cosmos.Resolver(gateway, codec, fold, initial, Cosmos.CachingStrategy.NoCaching).Resolve
@@ -78,7 +78,7 @@ type Tests(testOutputHelper) =
7878
}
7979

8080
[<AutoData(SkipIfRequestedViaEnvironmentVariable="EQUINOX_INTEGRATION_SKIP_COSMOS")>]
81-
let ``Can roundtrip against Cosmos, correctly folding the events with With Projection`` args = Async.RunSynchronously <| async {
82-
let! service = arrange connectToSpecifiedCosmosOrSimulator createCosmosContext resolveCosmosStreamWithProjection
81+
let ``Can roundtrip against Cosmos, correctly folding the events with With Snapshotting`` args = Async.RunSynchronously <| async {
82+
let! service = arrange connectToSpecifiedCosmosOrSimulator createCosmosContext resolveCosmosStreamWithSnapshotStrategy
8383
do! act service args
8484
}

samples/Store/Integration/LogIntegration.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ type Tests() =
124124
let log = createLoggerWithMetricsExtraction buffer.Enqueue
125125
let! conn = connectToSpecifiedCosmosOrSimulator log
126126
let gateway = createCosmosContext conn batchSize
127-
let service = Backend.Cart.Service(log, CartIntegration.resolveCosmosStreamWithProjection gateway)
127+
let service = Backend.Cart.Service(log, CartIntegration.resolveCosmosStreamWithSnapshotStrategy gateway)
128128
let itemCount = batchSize / 2 + 1
129129
let cartId = % Guid.NewGuid()
130130
do! act buffer service itemCount context cartId skuId "EqxCosmos Tip " // one is a 404, one is a 200

src/Equinox.Cosmos/CosmosInternalJson.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ open System.IO
2626
open System.IO.Compression
2727

2828
/// Manages zipping of the UTF-8 json bytes to make the index record minimal from the perspective of the writer stored proc
29-
/// Only applied to snapshots in the Index
29+
/// Only applied to snapshots in the Tip
3030
type Base64ZipUtf8JsonConverter() =
3131
inherit JsonConverter()
3232
let pickle (input : byte[]) : string =

src/Equinox.MemoryStore/MemoryStore.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ exception private WrongVersionException of streamName: string * expected: int *
1313
[<NoEquality; NoComparison>]
1414
type ConcurrentDictionarySyncResult<'t> = Written of 't | Conflict of int
1515

16-
/// Response type for ConcurrentArrayStore.TrySync to communicate the outcome and updated state of a stream
16+
/// Response type for VolatileStore.TrySync to communicate the outcome and updated state of a stream
1717
[<NoEquality; NoComparison>]
1818
type ConcurrentArraySyncResult<'t> = Written of 't | Conflict of 't
1919

tests/Equinox.Cosmos.Integration/CosmosCoreIntegration.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type Tests(testOutputHelper) =
5555
test <@ AppendResult.Ok 6L = res @>
5656
test <@ [EqxAct.Append] = capture.ExternalCalls @>
5757
// We didnt request small batches or splitting so it's not dramatically more expensive to write N events
58-
verifyRequestChargesMax 40 // observed 38.95 // was 11
58+
verifyRequestChargesMax 41 // observed 40.78 // was 11
5959
}
6060

6161
// It's conceivable that in the future we might allow zero-length batches as long as a sync mechanism leveraging the etags and unfolds updote mechanisms
@@ -150,7 +150,7 @@ type Tests(testOutputHelper) =
150150
let extrasCount = match extras with x when x > 50 -> 5000 | x when x < 1 -> 1 | x -> x*100
151151
let! _pos = ctx.NonIdempotentAppend(stream, TestEvents.Create (int pos,extrasCount))
152152
test <@ [EqxAct.Append] = capture.ExternalCalls @>
153-
verifyRequestChargesMax 300 // 251.39 observed
153+
verifyRequestChargesMax 460 // 451.01 observed
154154
capture.Clear()
155155

156156
let! pos = ctx.Sync(stream,?position=None)

tests/Equinox.Cosmos.Integration/CosmosFixturesInfrastructure.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ type AutoDataAttribute() =
2929
// Derived from https://github.com/damianh/CapturingLogOutputWithXunit2AndParallelTests
3030
// NB VS does not surface these atm, but other test runners / test reports do
3131
type TestOutputAdapter(testOutput : Xunit.Abstractions.ITestOutputHelper) =
32-
let formatter = Serilog.Formatting.Display.MessageTemplateTextFormatter("{Timestamp:yyyy-MM-dd HH:mm:ss.fff zzz} [{Level}] {Message}{NewLine}{Exception}", null);
32+
let formatter = Serilog.Formatting.Display.MessageTemplateTextFormatter("{Timestamp:yyyy-MM-dd HH:mm:ss.fff zzz} [{Level}] {Message}{NewLine}{Properties}{Exception}", null);
3333
let writeSerilogEvent logEvent =
3434
use writer = new System.IO.StringWriter()
35-
formatter.Format(logEvent, writer);
35+
formatter.Format(logEvent, writer)
3636
writer |> string |> testOutput.WriteLine
3737
interface Serilog.Core.ILogEventSink with member __.Emit logEvent = writeSerilogEvent logEvent
3838

0 commit comments

Comments
 (0)