fix(valid-expect-in-promise): check number of arguments being passed

Author: G-Rath

src/rules/__tests__/valid-expect-in-promise.test.ts

@@ -120,15 +120,14 @@ ruleTester.run('valid-expect-in-promise', rule, {
         });
       });
     `,
-    // todo: tighter "is promise" check
-    // dedent`
-    //   it('it1', function () {
-    //     Promise.resolve().then(/*fulfillment*/ function () {
-    //     }, undefined, /*rejection*/ function () {
-    //       expect(someThing).toEqual(true)
-    //     })
-    //   });
-    // `,
+    dedent`
+      it('it1', function () {
+        Promise.resolve().then(/*fulfillment*/ function () {
+        }, undefined, /*rejection*/ function () {
+          expect(someThing).toEqual(true)
+        })
+      });
+    `,
     dedent`
       it('it1', function () {
         return Promise.resolve().then(function () {

src/rules/valid-expect-in-promise.ts

@@ -19,11 +19,27 @@ type ThenOrCatchCallExpression = KnownCallExpression<'then' | 'catch'>;
 
 const isThenOrCatchCall = (
   node: TSESTree.Node,
-): node is ThenOrCatchCallExpression =>
-  node.type === AST_NODE_TYPES.CallExpression &&
-  node.callee.type === AST_NODE_TYPES.MemberExpression &&
-  isSupportedAccessor(node.callee.property) &&
-  ['then', 'catch'].includes(getAccessorValue(node.callee.property));
+): node is ThenOrCatchCallExpression => {
+  if (
+    node.type === AST_NODE_TYPES.CallExpression &&
+    node.callee.type === AST_NODE_TYPES.MemberExpression &&
+    isSupportedAccessor(node.callee.property)
+  ) {
+    // promise methods should have at least 1 argument
+    if (node.arguments.length === 0) {
+      return false;
+    }
+
+    switch (getAccessorValue(node.callee.property)) {
+      case 'then':
+        return node.arguments.length < 3;
+      case 'catch':
+        return node.arguments.length < 2;
+    }
+  }
+
+  return false;
+};
 
 const reportReturnRequired = (context: RuleContext, node: TSESTree.Node) => {
   context.report({