rename chart_instance to chartInstance #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You forgot to change this in typescript file: https://github.com/jerairrest/react-chartjs-2/blob/master/index.d.ts#L37 This broken typescript app. |
benmccann
added a commit
that referenced
this pull request
Jan 29, 2018
|
Fixed 5a362c6. Thanks for reporting |
|
Thank you for the speed. When will this be available in npm? |
|
I'll leave that question to @jerairrest |
|
Hi, the new variable rename should publish to npm. Thanks |
|
This should be pushed now. |
techwizard210
pushed a commit
to techwizard210/react-chartjs-2
that referenced
this pull request
Aug 28, 2022
happyboy000916
added a commit
to happyboy000916/react-chartjs-2
that referenced
this pull request
May 31, 2023
space7dev
added a commit
to space7dev/React-Chart.JS-Development
that referenced
this pull request
Sep 21, 2023
wakeup0706
added a commit
to wakeup0706/react-chartjs-2
that referenced
this pull request
Feb 13, 2025
cedricdumitru
pushed a commit
to cedricdumitru/react-chartjs-2
that referenced
this pull request
Aug 10, 2025
cedricdumitru
pushed a commit
to cedricdumitru/react-chartjs-2
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benmccann