Skip to content

Commit 0078bfe

Browse files
authored
Use Util#rawEncode to encode URLs (#661)
1 parent b90591b commit 0078bfe

File tree

3 files changed

+12
-3
lines changed
  • src

3 files changed

+12
-3
lines changed

src/main/resources/hudson/tasks/junit/ClassResult/body.jelly

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ THE SOFTWARE.
4141
<j:forEach var="p" items="${it.children}" varStatus="status">
4242
<tr>
4343
<td class="pane">
44-
<a href="${h.urlEncode(p.safeName)}"><span style="${p.previousResult==null?'font-weight:bold':''}"><st:out value="${p.displayName}" /></span></a>
44+
<j:invokeStatic var="encodedSafeName" className="hudson.Util" method="rawEncode">
45+
<j:arg value="${p.safeName}" />
46+
</j:invokeStatic>
47+
<a href="${encodedSafeName}"><span style="${p.previousResult==null?'font-weight:bold':''}"><st:out value="${p.displayName}" /></span></a>
4548
<j:forEach var="badge" items="${p.testActions}">
4649
<st:include it="${badge}" page="badge.jelly" optional="true"/>
4750
</j:forEach>

src/main/resources/hudson/tasks/test/MetaTabulatedResult/body.jelly

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,10 @@ THE SOFTWARE.
8181
<j:set var="prev" value="${prevAll.findCorrespondingResult(p.id)}" />
8282
<tr>
8383
<td class="pane">
84-
<a href="${h.urlEncode(p.safeName)}/" class="body.jelly"><span style="${prev==null?'font-weight:bold':''}"><st:out value="${p.displayName}" /></span></a>
84+
<j:invokeStatic var="encodedSafeName" className="hudson.Util" method="rawEncode">
85+
<j:arg value="${p.safeName}" />
86+
</j:invokeStatic>
87+
<a href="${encodedSafeName}/" class="body.jelly"><span style="${prev==null?'font-weight:bold':''}"><st:out value="${p.displayName}" /></span></a>
8588
<j:forEach var="badge" items="${p.testActions}">
8689
<st:include it="${badge}" page="badge.jelly" optional="true"/>
8790
</j:forEach>

src/test/resources/hudson/tasks/test/TrivialTestResult/body.jelly

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,10 @@ THE SOFTWARE.
8585
<j:set var="prev" value="${p.previousResult}" />
8686
<tr>
8787
<td class="pane">
88-
<a href="${h.urlEncode(p.safeName)}/"><span style='${prev==null?"font-weight:bold":""}'>${p.name}</span></a>
88+
<j:invokeStatic var="encodedSafeName" className="hudson.Util" method="rawEncode">
89+
<j:arg value="${p.safeName}" />
90+
</j:invokeStatic>
91+
<a href="${encodedSafeName}/"><span style='${prev==null?"font-weight:bold":""}'>${p.name}</span></a>
8992
<st:nbsp/>
9093
<j:forEach var="badge" items="${p.testActions}">
9194
<st:include it="${badge}" page="badge.jelly" optional="true"/>

0 commit comments

Comments
 (0)