Skip to content

Commit 5341700

Browse files
Fix source record timestamp -- seconds to milliseconds (#26)
* Update redis source timestamp from seconds to milliseconds (#1) * updated source record converter timestamp * removed logging * updated version and changelog * fixed changelog message improvement Co-authored-by: Jared Petersen <[email protected]>
1 parent 69baf71 commit 5341700

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [1.2.3] - 2022-03-15
8+
### Fixed
9+
- Fixed a bug with record timestamps for the source connector -- switched from epoch seconds (incorrect) to epoch milliseconds
10+
711
## [1.2.2] - 2021-07-22
812
### Changed
913
- Use capitalization in log messages

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>io.github.jaredpetersen</groupId>
77
<artifactId>kafka-connect-redis</artifactId>
8-
<version>1.2.2</version>
8+
<version>1.2.3</version>
99
<packaging>jar</packaging>
1010

1111
<name>Kafka Redis Connector (Sink and Source)</name>

src/main/java/io/github/jaredpetersen/kafkaconnectredis/source/listener/RecordConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public SourceRecord convert(RedisMessage redisMessage) {
5555
key,
5656
VALUE_SCHEMA,
5757
value,
58-
Instant.now().getEpochSecond()
58+
Instant.now().toEpochMilli()
5959
);
6060
}
6161
}

src/test/unit/java/io/github/jaredpetersen/kafkaconnectredis/source/listener/RecordConverterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ void convertTransformsRedisMessageToSourceRecord() {
3232
assertEquals(redisMessage.getPattern(), ((Struct) sourceRecord.key()).getString("pattern"));
3333
assertEquals(Schema.Type.STRUCT, sourceRecord.valueSchema().type());
3434
assertEquals(redisMessage.getMessage(), ((Struct) sourceRecord.value()).getString("message"));
35-
assertTrue(sourceRecord.timestamp() <= Instant.now().getEpochSecond());
35+
assertTrue(sourceRecord.timestamp() <= Instant.now().toEpochMilli());
3636
}
3737
}

0 commit comments

Comments
 (0)