feat(get): added support for multiple URIs to a directory

Author: itzg

src/main/java/me/itzg/helpers/get/GetCommand.java

@@ -1,10 +1,12 @@
 package me.itzg.helpers.get;
 
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.List;
 import java.util.concurrent.Callable;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.hc.client5.http.classic.methods.HttpGet;
@@ -30,6 +32,9 @@ public class GetCommand implements Callable<Integer> {
     @Option(names = "--output-filename", description = "Output the resulting filename")
     boolean outputFilename;
 
+    @Option(names = "--log-progress-each", description = "Output a log as each URI is being retrieved")
+    boolean logProgressEach;
+
     @Option(names = "--json-path",
         description = "Extract and output a JsonPath from the response")
     String jsonPath;
@@ -41,42 +46,40 @@ public class GetCommand implements Callable<Integer> {
         paramLabel = "FILE|DIR")
     Path outputFile;
 
-    @Parameters(arity = "1")
-    URI uri;
+    @Parameters(arity = "1..", split = ",", paramLabel = "URI",
+        description = "The URI of the resource to retrieve. When the output is a directory,"
+        + " more than one URI can be requested.")
+    List<URI> uris;
 
     @Override
-    public Integer call() throws Exception {
+    public Integer call() {
         final LatchingUrisInterceptor interceptor = new LatchingUrisInterceptor();
 
         try (CloseableHttpClient client = HttpClients.custom()
             .addExecInterceptorFirst("latchRequestUris", interceptor)
             .build()) {
 
-            final URI requestUri = this.uri.getPath().startsWith("//") ?
-                alterUriPath(this.uri.getPath().substring(1)) : this.uri;
-
-            log.debug("GETing uri={}", requestUri);
-
-            final HttpGet request = new HttpGet(requestUri);
-
             final PrintWriter stdout = spec.commandLine().getOut();
 
-            final HttpClientResponseHandler<String> handler;
             if (jsonPath != null) {
-                handler = new JsonPathOutputHandler(stdout, jsonPath);
+                assertSingleUri();
+                processSingleUri(uris.get(0), client, stdout, new JsonPathOutputHandler(stdout, jsonPath));
             }
             else if (outputFile == null) {
-                handler = new PrintWriterHandler(stdout);
+                assertSingleUri();
+                processSingleUri(uris.get(0), client, stdout, new PrintWriterHandler(stdout));
             } else if (Files.isDirectory(outputFile)) {
-                handler = new OutputToDirectoryHandler(outputFile, interceptor);
+                processUris(uris, client, stdout,
+                    interceptor::reset, new OutputToDirectoryHandler(outputFile, interceptor));
             } else {
-                handler = new SaveToFileHandler(outputFile);
+                assertSingleUri();
+                processSingleUri(uris.get(0), client, stdout, new SaveToFileHandler(outputFile));
             }
 
-            final String filename = client.execute(request, handler);
-            if (outputFilename) {
-                stdout.println(filename);
-            }
+        } catch (IllegalArgumentException e) {
+            log.error("Invalid usage: {}", e.getMessage());
+            log.debug("Details", e);
+            return ExitCode.USAGE;
         } catch (Exception e) {
             log.error("Failed to download: {}", e.getMessage());
             log.debug("Details", e);
@@ -86,7 +89,43 @@ else if (outputFile == null) {
         return ExitCode.OK;
     }
 
-    private URI alterUriPath(String path) throws URISyntaxException {
+    private void processUris(List<URI> uris, CloseableHttpClient client, PrintWriter stdout,
+        Runnable reset, HttpClientResponseHandler<String> handler) throws URISyntaxException, IOException {
+        for (URI uri : uris) {
+            processSingleUri(uri, client, stdout, handler);
+            reset.run();
+        }
+    }
+
+    private void processSingleUri(URI uri, CloseableHttpClient client, PrintWriter stdout,
+        HttpClientResponseHandler<String> handler) throws URISyntaxException, IOException {
+        final URI requestUri = uri.getPath().startsWith("//") ?
+            alterUriPath(uri, uri.getPath().substring(1)) : uri;
+
+        if (logProgressEach) {
+            log.info("Getting {}", requestUri);
+        }
+        else {
+            log.debug("GETing uri={}", requestUri);
+        }
+
+        final HttpGet request = new HttpGet(requestUri);
+
+        final String filename = client.execute(request, handler);
+        if (outputFilename) {
+            stdout.println(filename);
+        }
+    }
+
+    private void assertSingleUri() {
+        if (uris.size() > 1) {
+            log.debug("Too many URIs: {}", uris);
+            throw new IllegalArgumentException(
+                "Multiple URIs can only be used with an output directory");
+        }
+    }
+
+    private static URI alterUriPath(URI uri, String path) throws URISyntaxException {
         return new URI(
             uri.getScheme(),
             uri.getAuthority(),

src/main/java/me/itzg/helpers/get/LatchingUrisInterceptor.java

@@ -37,4 +37,8 @@ public ClassicHttpResponse execute(ClassicHttpRequest request, Scope scope, Exec
   public URI getLastRequestedUri() {
     return uris.peekFirst();
   }
+
+  public void reset() {
+    uris.clear();
+  }
 }