Merge branch 'master' of github.com:itinance/react-native-fs

* 'master' of github.com:itinance/react-native-fs:
  Make inner variables final
  Add missing AsyncTask import
  Typo fixes
  Use AsyncTask for copyFileTask so that it occurs in a background thread rather than blocking the UI thread while the copy takes place
  Fix more types
  Fix types
  Typescript type definitions
  Use the correct parameters for the native Windows implementation of the 'writeFile' function.
  PMP-5747 Fix EISDIR on stat directory
  Add missing  arg to moveFile
  Fix windows dev environment
  Fix crash with large downloads
  Add missing `options` arguments
  Fix compatibility with latest `react-native-windows`
  Update README.md
  Update README.md
  Add scanFile method (Android only)

Author: itinance

FS.common.js

@@ -569,6 +569,10 @@ var RNFS = {
     );
   },
 
+  scanFile(path: string): Promise<ReadDirItem[]> {
+    return RNFSManager.scanFile(path);
+  },
+
   MainBundlePath: RNFSManager.RNFSMainBundlePath,
   CachesDirectoryPath: RNFSManager.RNFSCachesDirectoryPath,
   ExternalCachesDirectoryPath: RNFSManager.RNFSExternalCachesDirectoryPath,

README.md

@@ -370,6 +370,8 @@ The following constants are available on the `RNFS` export:
 - `ExternalDirectoryPath` (`String`) The absolute path to the external files, shared directory (android only)
 - `ExternalStorageDirectoryPath` (`String`) The absolute path to the external storage, shared directory (android only)
 
+IMPORTANT: when using `ExternalStorageDirectoryPath` it's necessary to request permissions (on Android) to read and write on the external storage, here an example: [React Native Offical Doc] (https://facebook.github.io/react-native/docs/permissionsandroid)
+
 ### `readDir(dirpath: string): Promise<ReadDirItem[]>`
 
 Reads the contents of `path`. This must be an absolute path. Use the above path constants to form a usable file path.
@@ -694,6 +696,10 @@ type FSInfoResult = {
 };
 ```
 
+### (Android only) `scanFile(path: string): Promise<string[]>`
+
+Scan the file using [Media Scanner](https://developer.android.com/reference/android/media/MediaScannerConnection).
+
 ### (Android only) `getAllExternalFilesDirs(): Promise<string[]>`
 
 Returns an array with the absolute paths to application-specific directories on all shared/external storage devices where the application can place persistent files it owns.

android/src/main/java/com/rnfs/RNFSManager.java

@@ -4,12 +4,15 @@
 import android.content.res.AssetManager;
 import android.database.Cursor;
 import android.net.Uri;
+import android.os.AsyncTask;
 import android.os.Environment;
 import android.os.StatFs;
 import android.provider.MediaStore;
 import android.support.annotation.Nullable;
 import android.util.Base64;
 import android.util.SparseArray;
+import android.media.MediaScannerConnection;
+import android.net.Uri;
 
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.Promise;
@@ -66,21 +69,21 @@ public String getName() {
     return "RNFSManager";
   }
 
-  private Uri getFileUri(String filepath) throws IORejectionException {
+  private Uri getFileUri(String filepath, boolean isDirectoryAllowed) throws IORejectionException {
     Uri uri = Uri.parse(filepath);
     if (uri.getScheme() == null) {
       // No prefix, assuming that provided path is absolute path to file
       File file = new File(filepath);
-      if (file.isDirectory()) {
+      if (!isDirectoryAllowed && file.isDirectory()) {
         throw new IORejectionException("EISDIR", "EISDIR: illegal operation on a directory, read '" + filepath + "'");
       }
       uri = Uri.parse("file://" + filepath);
     }
     return uri;
   }
 
-  private String getOriginalFilepath(String filepath) throws IORejectionException {
-    Uri uri = getFileUri(filepath);
+  private String getOriginalFilepath(String filepath, boolean isDirectoryAllowed) throws IORejectionException {
+    Uri uri = getFileUri(filepath, isDirectoryAllowed);
     String originalFilepath = filepath;
     if (uri.getScheme().equals("content")) {
       try {
@@ -95,7 +98,7 @@ private String getOriginalFilepath(String filepath) throws IORejectionException
   }
 
   private InputStream getInputStream(String filepath) throws IORejectionException {
-    Uri uri = getFileUri(filepath);
+    Uri uri = getFileUri(filepath, false);
     InputStream stream;
     try {
       stream = reactContext.getContentResolver().openInputStream(uri);
@@ -109,7 +112,7 @@ private InputStream getInputStream(String filepath) throws IORejectionException
   }
 
   private OutputStream getOutputStream(String filepath, boolean append) throws IORejectionException {
-    Uri uri = getFileUri(filepath);
+    Uri uri = getFileUri(filepath, false);
     OutputStream stream;
     try {
       stream = reactContext.getContentResolver().openOutputStream(uri, append ? "wa" : "w");
@@ -316,46 +319,69 @@ public void hash(String filepath, String algorithm, Promise promise) {
   }
 
   @ReactMethod
-  public void moveFile(String filepath, String destPath, ReadableMap options, Promise promise) {
+  public void moveFile(final String filepath, String destPath, ReadableMap options, final Promise promise) {
     try {
-      File inFile = new File(filepath);
+      final File inFile = new File(filepath);
 
       if (!inFile.renameTo(new File(destPath))) {
-        copyFile(filepath, destPath);
-
-        inFile.delete();
+        new CopyFileTask() {
+          @Override
+          protected void onPostExecute (Exception ex) {
+            if (ex == null) {
+              inFile.delete();
+              promise.resolve(true);
+            } else {
+              ex.printStackTrace();
+              reject(promise, filepath, ex);
+            }
+          }
+        }.execute(filepath, destPath);
+      } else {
+          promise.resolve(true);
       }
-
-      promise.resolve(true);
     } catch (Exception ex) {
       ex.printStackTrace();
       reject(promise, filepath, ex);
     }
   }
 
   @ReactMethod
-  public void copyFile(String filepath, String destPath, ReadableMap options, Promise promise) {
-    try {
-      copyFile(filepath, destPath);
-
-      promise.resolve(null);
-    } catch (Exception ex) {
-      ex.printStackTrace();
-      reject(promise, filepath, ex);
-    }
+  public void copyFile(final String filepath, final String destPath, ReadableMap options, final Promise promise) {
+    new CopyFileTask() {
+      @Override
+      protected void onPostExecute (Exception ex) {
+        if (ex == null) {
+          promise.resolve(null);
+        } else {
+          ex.printStackTrace();
+          reject(promise, filepath, ex);
+        }
+      }
+    }.execute(filepath, destPath);
   }
 
-  private void copyFile(String filepath, String destPath) throws IOException, IORejectionException {
-    InputStream in = getInputStream(filepath);
-    OutputStream out = getOutputStream(destPath, false);
+  private class CopyFileTask extends AsyncTask<String, Void, Exception> {
+    protected Exception doInBackground(String... paths) {
+      try {
+        String filepath = paths[0];
+        String destPath = paths[1];
 
-    byte[] buffer = new byte[1024];
-    int length;
-    while ((length = in.read(buffer)) > 0) {
-      out.write(buffer, 0, length);
+        InputStream in = getInputStream(filepath);
+        OutputStream out = getOutputStream(destPath, false);
+
+        byte[] buffer = new byte[1024];
+        int length;
+        while ((length = in.read(buffer)) > 0) {
+          out.write(buffer, 0, length);
+          Thread.yield();
+        }
+        in.close();
+        out.close();
+        return null;
+      } catch (Exception ex) {
+        return ex;
+      }
     }
-    in.close();
-    out.close();
   }
 
   @ReactMethod
@@ -532,7 +558,7 @@ public void setReadable(String filepath, Boolean readable, Boolean ownerOnly, Pr
   @ReactMethod
   public void stat(String filepath, Promise promise) {
     try {
-      String originalFilepath = getOriginalFilepath(filepath);
+      String originalFilepath = getOriginalFilepath(filepath, true);
       File file = new File(originalFilepath);
 
       if (!file.exists()) throw new Exception("File does not exist");
@@ -597,8 +623,8 @@ public void mkdir(String filepath, ReadableMap options, Promise promise) {
 
   private void sendEvent(ReactContext reactContext, String eventName, @Nullable WritableMap params) {
     reactContext
-        .getJSModule(RCTNativeAppEventEmitter.class)
-        .emit(eventName, params);
+            .getJSModule(RCTNativeAppEventEmitter.class)
+            .emit(eventName, params);
   }
 
   @ReactMethod
@@ -816,6 +842,22 @@ public void getAllExternalFilesDirs(Promise promise){
     promise.resolve(fs);
   }
 
+  @ReactMethod
+  public void scanFile(String path, final Promise promise) {
+    MediaScannerConnection.scanFile(this.getReactApplicationContext(),
+      new String[]{path},
+      null,
+      new MediaScannerConnection.MediaScannerConnectionClient() {
+        @Override
+        public void onMediaScannerConnected() {}
+         @Override
+        public void onScanCompleted(String path, Uri uri) {
+          promise.resolve(path);
+        }
+      }
+    );
+  }
+
   private void reject(Promise promise, String filepath, Exception ex) {
     if (ex instanceof FileNotFoundException) {
       rejectFileNotFound(promise, filepath);