Skip to content

Commit 6890d86

Browse files
authored
Revert "Build JavaScript files during python package build" (#798)
This reverts commit bbad14e. Reason for revert: The change broke `sdist` (source distribution) installs (which will attempt to run `make` even when *installing*, but neither `Makefile` nor `package.json` are inlcuded in the tarball (see `MANIFEST.in`), so the command will fail.
1 parent 24a36ff commit 6890d86

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

setup.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,12 @@
11
#!/usr/bin/env python3
22
# -*- encoding: utf-8 -*-
33

4-
import os
5-
import setuptools.command.build_py
6-
import subprocess
7-
84
from setuptools import setup, find_packages
95

106
requires = ['itsdangerous', 'Jinja2', 'misaka>=2.0,<3.0', 'html5lib',
117
'werkzeug>=1.0', 'bleach', 'Flask-Caching>=1.9', 'Flask']
128
tests_require = ['pytest', 'pytest-cov']
139

14-
15-
class NpmBuildCommand(setuptools.command.build_py.build_py):
16-
"""Prefix Python build with node-based asset build"""
17-
18-
def run(self):
19-
# https://tox.wiki/en/latest/config.html#injected-environment-variables
20-
if 'TOX_ENV_NAME' not in os.environ:
21-
subprocess.check_call(['make', 'init', 'js'])
22-
setuptools.command.build_py.build_py.run(self)
23-
24-
2510
setup(
2611
name='isso',
2712
version='0.12.5',
@@ -52,7 +37,4 @@ def run(self):
5237
'console_scripts':
5338
['isso = isso:main'],
5439
},
55-
cmdclass={
56-
'build_py': NpmBuildCommand,
57-
},
5840
)

0 commit comments

Comments
 (0)