Skip to content

Commit 09e797d

Browse files
committed
Fix missing null check for fasttrack endpoint
I believe that not providing an upper concept should be the same as providing a blank upper concept.
1 parent 8df3ab8 commit 09e797d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/java/uk/ac/cam/cl/dtg/isaac/api/GameboardsFacade.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ public final Response getFastTrackConceptFromHistory(@Context final Request requ
311311
this.questionManager.getQuestionAttemptsByUser(currentUser);
312312

313313
List<GameboardItem> conceptQuestionsProgress = Lists.newArrayList();
314-
if (upperQuestionId.isEmpty()) {
314+
if (null == upperQuestionId || upperQuestionId.isEmpty()) {
315315
List<FASTTRACK_LEVEL> upperAndLower = Arrays.asList(FASTTRACK_LEVEL.ft_upper, FASTTRACK_LEVEL.ft_lower);
316316
conceptQuestionsProgress.addAll(fastTrackManger.getConceptProgress(
317317
gameboard, upperAndLower, currentConceptTitle, userQuestionAttempts));

0 commit comments

Comments
 (0)