Skip to content

Commit 157c6b7

Browse files
Adds scene update to ManagerBasedEnv and DirectRLEnv initialization (#1809)
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> This PR fixes execution of imu (and other sensor) based observation by updating the scene at the initialization of ManagerBasedEnv and DirectRLEnv. This ensures the Imu._dt (and any other scene buffers) are set before extracting Imu.data. Fixes #1423 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: James Tigue <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
1 parent 62bbf61 commit 157c6b7

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

source/isaaclab/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.33.16"
4+
version = "0.33.17"
55

66
# Description
77
title = "Isaac Lab framework for Robot Learning"

source/isaaclab/docs/CHANGELOG.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.33.17 (2025-02-13)
5+
~~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Fixed Imu sensor based observations at first step by updating scene during :meth:`~isaaclab.envs.ManagerBasedEnv.init`
11+
12+
413
0.33.16 (2025-02-09)
514
~~~~~~~~~~~~~~~~~~~~
615

@@ -27,6 +36,7 @@ Fixed
2736

2837
* Fixed not updating the timestamp of ``body_link_state_w`` and ``body_com_state_w`` when ``write_root_pose_to_sim`` and ``write_joint_state_to_sim`` in the ``Articulation`` class are called.
2938

39+
3040
0.33.13 (2025-01-30)
3141
~~~~~~~~~~~~~~~~~~~~
3242

source/isaaclab/isaaclab/envs/direct_rl_env.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ def __init__(self, cfg: DirectRLEnvCfg, render_mode: str | None = None, **kwargs
139139
print("[INFO]: Starting the simulation. This may take a few seconds. Please wait...")
140140
with Timer("[INFO]: Time taken for simulation start", "simulation_start"):
141141
self.sim.reset()
142+
self.scene.update(dt=self.physics_dt)
142143

143144
# -- event manager used for randomization
144145
if self.cfg.events:

source/isaaclab/isaaclab/envs/manager_based_env.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ def __init__(self, cfg: ManagerBasedEnvCfg):
139139
print("[INFO]: Starting the simulation. This may take a few seconds. Please wait...")
140140
with Timer("[INFO]: Time taken for simulation start", "simulation_start"):
141141
self.sim.reset()
142-
# add timeline event to load managers
142+
# add timeline event to load managers
143+
self.scene.update(dt=self.physics_dt)
143144
self.load_managers()
144145

145146
# make sure torch is running on the correct device

0 commit comments

Comments
 (0)